Repository navigation
Remove zero width space when copying email - #35557
Conversation
|
@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| return <Text style={[styles.breakWord, styles.textLabelSupporting, styles.textStrong]}>{tnode.data}</Text>; | ||
| return ( | ||
| <Text | ||
| testID="email-with-break-opportunities" |
There was a problem hiding this comment.
Can we use nativeID instead of testID, in the past we had an issue with using testID and as far as I know testID should be used only for testing purposes. Context: https://github.com/Expensify/App/pull/33265/files#r1437244150
There was a problem hiding this comment.
I'm sorry I missed this. Work on it now.
Reviewer Checklist
Screenshots/VideosAndroid: NativeN/aAndroid: mWeb ChromeN/aiOS: NativeN/aiOS: mWeb SafariN/aMacOS: Chrome / Safaricopy-web.movMacOS: Desktopcopy-desktop.mov |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.4.36-5 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
1 similar comment
|
🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.4.36-5 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
This PR is failing because of known issue #34437 |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.37-7 🚀
|
Details
This PR removes the zero width space character when copying email causing the copied email to fail form validation.
Fixed Issues
$ #34437
PROPOSAL: #34437 (comment)
Tests
Preconditions:
=======
For mWeb & Native
applausetester+06075lsn@applause.expensifail.com)Offline tests
NA
QA Steps
Preconditions:
=======
For mWeb & Native
applausetester+06075lsn@applause.expensifail.com)PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2024-02-01.at.21.41.26-compressed.mov
Android: mWeb Chrome
Screen.Recording.2024-02-01.at.21.44.35-compressed.mov
iOS: Native
Screen.Recording.2024-02-01.at.21.36.42-compressed.mov
iOS: mWeb Safari
Screen.Recording.2024-02-01.at.21.34.44-compressed.mov
MacOS: Chrome / Safari
MacOS: Desktop
Screen.Recording.2024-02-01.at.21.30.20-compressed.mov