Repository navigation
fixes crash on long press expensify classic option - #35601
Conversation
|
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
PR is open for review. |
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid-redirect-expensify-classic.movandroid-long-press-expensify-classic.movAndroid: mWeb Chromemweb-chrome-redirect-expensify-classic.movmweb-chrome-long-press-expensify-classic.moviOS: Nativeios-long-press-expensify-classic.moviOS: mWeb Safarimweb-safari-redirect-expensify-classic.movmweb-safari-long-press-expensify-classic.movMacOS: Chrome / Safariweb-redirect-expensify-classic.movMacOS: Desktopdesktop-redirect-expensify-classic.mov |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.4.36-5 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
1 similar comment
|
🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.4.36-5 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.37-7 🚀
|
| onSecondaryInteraction={ | ||
| !_.isEmpty(item.link) ? (e) => ReportActionContextMenu.showContextMenu(CONST.CONTEXT_MENU_TYPES.LINK, e, item.link, popoverAnchor.current) : undefined | ||
| } | ||
| onSecondaryInteraction={item.link ? (event) => openPopover(item.link, event) : undefined} |
There was a problem hiding this comment.
coming from - #60783
this caused a minor bug related to longpress and tooltips
Details
Fixed Issues
$ #35310
PROPOSAL: #35310 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2024-02-02.at.4.29.06.AM.mov
Android: mWeb Chrome
Screen.Recording.2024-02-02.at.5.02.34.AM.mov
iOS: Native
Screen.Recording.2024-02-02.at.4.11.31.AM.mov
iOS: mWeb Safari
Screen.Recording.2024-02-02.at.5.13.11.AM.mov
MacOS: Chrome / Safari
Screen.Recording.2024-02-02.at.4.31.51.AM.mov
MacOS: Desktop
Screen.Recording.2024-02-02.at.5.49.25.AM.mov