Repository navigation
Hide Subscriptions menu item on iOS and Android native - #35953
Conversation
|
@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@codinggeek2023 you should not create PR until assignment. But I understand this is exception. |
aimane-chnaif
left a comment
There was a problem hiding this comment.
Please see shouldDelayFocus for reference.
- index.native.ts
- index.ts
- types.ts (you missed this)
And better to define as value instead of function.
|
okay give me few minutes |
|
sorry for the overlook, here's the final PR @aimane-chnaif :) |
Co-authored-by: Aimane Chnaif <96077027+aimane-chnaif@users.noreply.github.com>
Co-authored-by: Aimane Chnaif <96077027+aimane-chnaif@users.noreply.github.com>
Co-authored-by: Aimane Chnaif <96077027+aimane-chnaif@users.noreply.github.com>
Co-authored-by: Aimane Chnaif <96077027+aimane-chnaif@users.noreply.github.com>
|
Pushed the suggested changes :) @aimane-chnaif , i thought we need to implement this as a function sorry about that |
|
rename folder: - libs/ShouldShowSubscriptionsMenu
+ libs/shouldShowSubscriptionsMenu |
|
QA Steps is wrong. Did you copy from any previous PR? |
|
Yes, fixed the QA step now, please check :) @aimane-chnaif
Fixed the import on settings page too |
Reviewer Checklist
Screenshots/Videos |
|
@codinggeek2023 please fix lint |
|
The lint check workflow is not enabled for the PR :), still i pushed the lint fix using vscode linter |
|
revert your last change. we're not using vscode linter |
|
okay |
|
Copy this code |
|
And add line break at the end of remaining 3 files |
|
Done with the suggested changes |
|
any thoughts on this @aimane-chnaif @luacmartins ? |
|
Perf tests are failing but they seem unrelated to this PR and probably due to cache. This PR is pretty important so I'm gonna merge it and request a CP. |
|
@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
See comment above about failing tests |
(cherry picked from commit ab472ec)
|
🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.4.37-4 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.37-7 🚀
|








Details
Fixed Issues
$ #35932
PROPOSAL: #35932 (comment)
Tests
Same as QA step
Offline tests
Same as QA step
QA Steps
Note: You will see the Subscription menu item on Web/Desktop but not on iOS/Android
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
iOS: Native
simplescreenrecorder-2024-02-07_01.54.56.mp4
MacOS: Desktop
Seeing the subscription as intendedsimplescreenrecorder-2024-02-07_01.50.14.mp4
MacOS: Chrome / Safari
Seeing the subscription as intendediOS: mWeb Safari
Seeing the subscription as intended
WhatsApp.Video.2024-02-07.at.1.46.59.AM.mp4
Android: mWeb Chrome
Android: Native