Repository navigation
Add missing params in vbba setup flow and clean up - #36689
Merged
Merged
Conversation
nkuoch
force-pushed
the
nat-policyvbba
branch
4 times, most recently
from
February 16, 2024 15:21
c3ab3bf to
8923ee8
Compare
nkuoch
force-pushed
the
nat-policyvbba
branch
from
February 16, 2024 17:26
8923ee8 to
db3b690
Compare
nkuoch
force-pushed
the
nat-policyvbba
branch
from
February 16, 2024 17:41
db3b690 to
2908c4f
Compare
nkuoch
marked this pull request as ready for review
February 16, 2024 17:43
nkuoch
force-pushed
the
nat-policyvbba
branch
from
February 16, 2024 19:44
581aef9 to
b65abec
Compare
melvin-bot
Bot
requested review from
DylanDylann
and removed request for
a team
February 16, 2024 20:26
Contributor
|
This PR is:
|
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Desktop |
situchan
reviewed
Feb 20, 2024
situchan
approved these changes
Feb 20, 2024
|
@hayata-suenaga Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
hayata-suenaga
approved these changes
Feb 20, 2024
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.4.44-0 🚀
|
1 of 6 tasks
2 of 6 tasks
Contributor
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Details
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/369943
Part of https://github.com/Expensify/Expensify/issues/299712
Tests
Start setting up a workspace bank account via Plaid (Plaid Savings).
Make sure you're redirected to the manual form.
Enter routing number 011401533 and account number 1111222233331112. You should get an error:

Open your Network console.
Replace account number by 1111222233331111. You should be redirected to the personal step.

Make sure the call ConnectBankAccountManually sent isSavings, plaidAccessToken, plaidMask and policyID

QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
See in Tests
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop