Repository navigation
fix: Chat - Download option in three-dot menu is still available in offline mode - #36918
Conversation
…ffline mode. Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>
|
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Adding screenshots in few minutes. |
|
Reviewing now |
Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>
|
@Krishna2323 Can you do a merge from main? I think the typescript checks are failing in main. |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-02-23.at.10.43.31.PM.mp4Android: mWeb ChromeScreen.Recording.2024-02-23.at.10.49.53.PM.mp4iOS: NativeScreen.Recording.2024-02-23.at.10.35.50.PM.mp4iOS: mWeb SafariScreen.Recording.2024-02-23.at.10.28.33.PM.mp4MacOS: Chrome / SafariScreen.Recording.2024-02-23.at.9.51.53.PM.mp4MacOS: DesktopScreen.Recording.2024-02-23.at.10.05.20.PM.mp4 |
abdulrahuman5196
left a comment
There was a problem hiding this comment.
Changes looks good and works well. Reviewers checklist is also complete.
All yours. @bondydaa
🎀 👀 🎀
C+ Reviewed
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/bondydaa in version: 1.4.44-0 🚀
|
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀
|
Details
Fixed Issues
$ #36901
PROPOSAL: #36901 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android_native.mp4
Android: mWeb Chrome
android_chrome.mp4
iOS: Native
ios_native.mp4
iOS: mWeb Safari
ios_safari.mp4
MacOS: Chrome / Safari
web_chrome.mp4
MacOS: Desktop
desktop_app.mp4