Repository navigation
[Re-fix]: "Invite a friend" banner do not move up when input field is focused in search page - #36931
Merged
Merged
Conversation
Contributor
Author
|
@c3024 , should i add videos for only mobile view or desktop view is also required ? |
Contributor
|
@Amarparab2024 Please upload for all. |
Contributor
|
Please add Test steps as well. @Amarparab2024 |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: NativebannerAndroid.mp4Android: mWeb ChromebannerAndroidChrome.mp4iOS: NativebanneriOS.mp4iOS: mWeb SafaribanneriOSSafari.mp4MacOS: Chrome / SafaribannerChrome.mp4MacOS: DesktopbannerDesktop.mp4 |
Contributor
|
Please refer to this comment. Earlier PR #35363 made the changes in |
Contributor
|
Don't forget to add QA steps. @Amarparab2024 |
stitesExpensify
approved these changes
Feb 21, 2024
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.4.44-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #35182
PROPOSAL: #35182 (comment)
(More of a redo from previous PR as these changes weren't included in the new searchPage file)
Tests
Same as QA step
Offline tests
Same as QA step
QA Steps
Note: This is only possible for native devices, cannot reproduce on safari laptop or MacOS application as this issue is related to keyboard pop up.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
iOS: mWeb Safari
Android: mWeb Chrome
iOS: Native
Android: Native
MacOS: Desktop
MacOS: Chrome / Safari