Repository navigation
fix: Add indenting logic for subcategories - #37456
Merged
Merged
Conversation
melvin-bot
Bot
requested review from
eVoloshchak
and removed request for
a team
February 28, 2024 22:09
|
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
Reviewer Checklist
Screenshots/Videos |
eVoloshchak
reviewed
Mar 4, 2024
Contributor
Author
|
@eVoloshchak ready for review! |
eVoloshchak
reviewed
Mar 12, 2024
eVoloshchak
left a comment
Contributor
There was a problem hiding this comment.
Native apps are crashing when navigating to Category screen (I suspect this is due to recent changes)
@neonbhai, could you merge the lates main please?
Screen.Recording.2024-03-12.at.21.05.50.mov
Contributor
|
@neonbhai, gentle bump on the above |
…-picker-indent-fix
Contributor
Author
|
@eVoloshchak merged main, RadioListItem moved to typescript so fixed some lint errors! |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






Details
We add indenting logic for the new
ListItemscomponent, that was created to replaceOptionRow. The indenting logic comes from here. This fixes the display of subcategories spanning more than one line.Fixed Issues
$ #37444
PROPOSAL: N/A
Tests
Prerequisite:
User is an employee of Collect workspace
The Collect workspace has a category with long subcategory (Lorem ipsum: Neque porro quisquam est qui dolorem ipsum quia dolor sit amet, consectetur, adipisci velit)
Offline tests
Same as Tests step
QA Steps
Same as Tests step
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop