Repository navigation
Fix failed to load PDF is shown while previewing a pdf receipt after going online - #38557
Conversation
|
@cubuspl42 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Is this enough? I thought that you needed some very heavy PDFs and/or other tricks to reproduce this issue. |
This a bad PR description. Maybe you meant starting with "Fixes an issue..."? |
|
I executed your testing steps on fix-load-pdf-repro-1-web-converted.mp4Any hints? |
Updated 👍
The issue only happens on native, can you test it on native? |
Nope, happens on physical device too. |
fix-load-pdf-repro-2-android-compressed.mp4Upstream |
|
Hmm, my only guess is the upload hasn't been completed yet. Here is the video of mine: Screen.Recording.2024-03-20.at.21.00.49.movI put another device beside it to see whether the receipt was successfully uploaded or not. |
|
Okey, good trick. I'll try waiting longer. |
Reviewer Checklist
Screenshots/VideosAndroid: Nativefix-pdf-receipt-reload-android-compressed.mp4Android: mWeb Chromefix-pdf-receipt-reload-android-web-compressed.mp4iOS: Nativefix-pdf-receipt-reload-ios-compressed.mp4iOS: mWeb Safarifix-pdf-receipt-reload-ios-web-compressed.mp4MacOS: Chrome / Safarifix-pdf-receipt-reload-web-converted.mp4MacOS: Desktop |
jakub-trzebiatowski
left a comment
There was a problem hiding this comment.
Please merge main
|
Merged with main |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |

Details
Fixes an issue where the attachment component tries to load a local file with an encrypted auth token which makes it unable to find the file.
Fixed Issues
$ #38224
PROPOSAL: #38224 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2024-03-19.at.15.54.40.mov
Android: mWeb Chrome
Screen.Recording.2024-03-19.at.15.56.53.mov
iOS: Native
Screen.Recording.2024-03-19.at.15.47.20.mov
iOS: mWeb Safari
Screen.Recording.2024-03-19.at.15.58.47.mov
MacOS: Chrome / Safari
Screen.Recording.2024-03-19.at.15.44.26.mov
MacOS: Desktop
Screen.Recording.2024-03-19.at.15.45.30.mov