Skip to content

[HOLD translations] Add existing owners error modal during bank account setup - #3928

Closed
jasperhuangg wants to merge 729 commits into
mainfrom
jasper-existingOwnersCopy
Closed

jasperhuangg wants to merge 729 commits into
mainfrom
jasper-existingOwnersCopy

Conversation

@jasperhuangg

@jasperhuangg jasperhuangg commented Jul 8, 2021 •

Copy link
Copy Markdown
Contributor

Details

Previously, setupWithdrawalAccount would silently error when a user tried to add a withdrawal bank account that we already assigned an owner to.

This PR adds some text similar to the text in Web-Secure.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/169896

Tests/QA

  1. Create a new workspace and click "Get Started".
  2. Add a bank account manually following the steps here.
  3. In a different account, follow steps 1 and 2.
  4. Verify that you're unable to add the account since the bank account already has an existing owner, and verify that the error step displays (see screenshots).

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

NOTE: I've since updated the header title to be capitalized [aka Existing Owners] (not shown in the screenshots below)

Desktop

Screen Shot 2021-07-13 at 3 32 18 PM

Web

Screen Shot 2021-07-13 at 3 34 47 PM

Mobile-Web

Screen Shot 2021-07-13 at 3 36 19 PM

Android

WechatIMG26

cc @marcaaron Can you verify if the testing steps are correct? I was unable to test entirely on dev because I can't hit the Web-Secure API.

@jasperhuangg jasperhuangg self-assigned this Jul 8, 2021
Comment thread src/languages/en.js Resolved
Comment thread src/languages/es.js Resolved
@jasperhuangg jasperhuangg changed the title Add growl notification when there are existing owners during withdrawal account setup Setup growl notification templates and add existing owners growl for bank account setup Jul 9, 2021
marcaaron and others added 26 commits July 19, 2021 10:01
Show a growl and redirect when navigating to a chat we can't access
Stop call to Get&rvl=reportStuff with reportID = undefined
[No QA] RenameGetPreferredCurrency API command to GetLocalCurrency
Use round avatar for E.Cash room avatar
…heck

Don't check participants' whole names in default rooms
Modify line height so text does not get cut off in LHN
…jasper-existingOwnersCopy

# Conflicts:
#	src/libs/actions/BankAccounts.js
@github-actions

Copy link
Copy Markdown
Contributor

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


16 out of 18 committers have signed the CLA.
✅ @jasperhuangg
✅ @rdjuric
✅ @roryabraham
✅ @marcaaron
✅ @parasharrajat
✅ @rushatgabhane
✅ @johncschuster
✅ @Luke9389
✅ @AndrewGable
✅ @thienlnam
✅ @mountiny
✅ @vitHoracek
✅ @pranshuchittora
✅ @tgolen
✅ @rafecolton
✅ @Jag96
❌ @madmax330
❌ @pecanoro
You can retrigger this bot by commenting recheck in this Pull Request

@jasperhuangg

Copy link
Copy Markdown
Contributor Author

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

16 out of 18 committers have signed the CLA.
✅ @jasperhuangg
✅ @rdjuric
✅ @roryabraham
✅ @marcaaron
✅ @parasharrajat
✅ @rushatgabhane
✅ @johncschuster
✅ @Luke9389
✅ @AndrewGable
✅ @thienlnam
✅ @mountiny
✅ @vitHoracek
✅ @pranshuchittora
✅ @tgolen
✅ @rafecolton
✅ @Jag96
❌ @madmax330
❌ @pecanoro
You can retrigger this bot by commenting recheck in this Pull Request

Sorry for all the mentions! Something happened when I was resolving a merge that led to this branch getting messed up. Please ignore this 😓

@coleaeason
coleaeason deleted the jasper-existingOwnersCopy branch May 19, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Payments - Unable to add bank fully verified account