Repository navigation
Fix: grey line SpacerView same padding as green line UnreadActionIndicator - #39297
Conversation
| ]; | ||
| }, [action, report.reportID]); | ||
|
|
||
| const renderThreadDivider = () => |
|
Weird glitch happening but I confirmed this also happens on main so out of scope Screen.Recording.2024-03-30.at.9.44.17.AM.mov |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
Bug: no unread indicator on transaction detail page Screen.Recording.2024-03-30.at.9.47.25.AM.mov |
situchan
left a comment
There was a problem hiding this comment.
I think this will fix above regression
|
Another bug: no unread indicator on normal chat first report action Screen.Recording.2024-03-30.at.10.26.33.AM.mov |
|
FYI: I am going on vacation next week. I think all good if above regressions are fixed. |
I spent the weekend trying to fix this one. It's a bit hard with the logic I used. Will try again tomorrow. |
|
Unassigning myself as a reviewer since I'm going to be OOO for the next 2 weeks and I think this also should have been auto-assigned to @Beamanator. |
|
I am AFK for 2 days. I wil fix all by Friday. |
|
@situchan regression fixed. |
|
Bump @situchan can you please review this today? 🙏 |
|
@DylanDylann I was not able to run the Android build. I will proceed with the updates now until I solve the Android thing. |
|
Updates done |
|
🎯 @DylanDylann, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #41080. |
|
I think the payment should be handled here |
Beamanator
left a comment
There was a problem hiding this comment.
Got a few small requested changes, thanks so much for continuing to push this through, @dragnoir 🙏
Also @dannymcclain @shawnborton are y'all interested in re-reviewing this PR before we merge?
|
@dragnoir Any update here? |
|
🎯 @DylanDylann, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #41304. |
|
@Beamanator all requested updates are done. |
Beamanator
left a comment
There was a problem hiding this comment.
Eek, sorry I meant to check this out yesterday!
|
Thanks for the hard work on this @dragnoir 🙏 |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.70-5 🚀
|
Details
This PR makes the padding below total consistent with the grey and the green lines.
Fixed Issues
$ #30360
PROPOSAL: #30360 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
20240330_004953.mp4
Android: mWeb Chrome
20240330_000631.mp4
iOS: Native
20240330_001311.mp4
iOS: mWeb Safari
20240330_001208.mp4
MacOS: Chrome / Safari
20240330_001459.mp4
MacOS: Desktop
20240330_001609.mp4