Repository navigation
fix: app shows full page notfound in ws features page - #39835
Conversation
|
@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@nkdengineer Sorry have been busy. I will review it tomorrow, meanwhile can you resolve conflicts |
|
@alitoshmatov please check again |
|
@nkdengineer In ios and android apps the back button is placed in the very top which is not normal, in ios it is not even possible to click not-found-ios.mp4Screen.Recording.2024-04-17.at.6.03.20.PM.mov |
|
@alitoshmatov please check again |
|
@alitoshmatov Friendly bump. |
Reviewer Checklist
Screenshots/VideosAndroid: Nativenot-found-android.movAndroid: mWeb ChromeiOS: Nativenot-found-ios.mp4iOS: mWeb Safarinot-found-safari.mp4MacOS: Chrome / Safarinot-found-web.movMacOS: Desktopnot-found-desktop.mov |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.4.65-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.65-5 🚀
|
Details
Fixed Issues
$ #39092
PROPOSAL: #39092 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov