Repository navigation
Format ISO string correctly when missing reportAction to find mostRecentReportActionLastModified - #40734
Merged
Conversation
|
@yuwenmemon Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
|
@marcaaron looks like you have some lint stuff to fix |
Contributor
Author
|
Oh woops sorry this was not ready for review. Meant to create a draft 🥲 |
marcaaron
marked this pull request as draft
April 23, 2024 00:17
marcaaron
marked this pull request as ready for review
April 23, 2024 00:38
Contributor
Author
|
Ok, this is ready now. Full disclosure I only tested this on web due to the relative simplicity of the change. We could have a C+ test it, but I am 99% sure it's fine. |
pecanoro
approved these changes
Apr 23, 2024
Contributor
|
Thank you for fixing this so quick! |
yuwenmemon
approved these changes
Apr 23, 2024
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
74 tasks done
Contributor
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 1.4.65-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.65-5 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @pecanoro as this came up in #39455, but not sure if causing the problem
Details
waf is tossing values when they are not formatted correctly. we initialize the
mostRecentReportActionLastModifiedwithnew Date(0).toISOString(), but need to get rid of theTandZfor it to pass the regex validation we use.Fixed Issues
Not really any specific issue.
Tests
Take this test with a grain of salt as I am not entirely sure how someone could end up in a situation where they do not have any
reportActions. But to confirm the changes are valid I:mostRecentReportActionLastModifiedGo offline
Come back online which should trigger a call to
ReconnectAppWe should see that the "before" value is a correct ISO formatted string and the "after" has a value (related to some report action). And verify that there is no

Tindicating the "time separator" orZ(indicating utc) at the end of the timestampVerify we do not see any logs like (which might be hard since you probably have some valid report actions):
Offline tests
❌
QA Steps
No specific QA for this. It's not an easily reproducible situation AFAICT.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Skipped because the change is very small and no UI.
Android: mWeb Chrome
Skipped because the change is very small and no UI.
iOS: Native
Skipped because the change is very small and no UI.
iOS: mWeb Safari
Skipped because the change is very small and no UI.
MacOS: Chrome / Safari
MacOS: Desktop
Skipped because the change is very small and no UI.