Skip to content

Clear push notifications when logging out - #4160

Merged
madmax330 merged 3 commits into
mainfrom
horus-remove-notification-badge-icon
Jul 22, 2021
Merged

madmax330 merged 3 commits into
mainfrom
horus-remove-notification-badge-icon

Conversation

@HorusGoul

Copy link
Copy Markdown
Contributor

Details

Check out the comments in this issue for more detail: #4112

Fixed Issues

$ #4112

Tests

I couldn't test on dev because the emulator doesn't receive push notifications.

QA Steps

  1. Log in to e.cash on Android or iOS
  2. Send a message from another account
  3. Navigate to the home screen and verify you have the notification badge on the app icon
  4. Navigate back to e.cash.
  5. Log out and force close the app.
  6. All push notifications should have been removed, and there should not be a notification badge indicator in the app's icon.

Tested On

I couldn't test on dev because the emulator doesn't receive push notifications.

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

N/A

@HorusGoul
HorusGoul requested a review from a team July 21, 2021 12:02
@HorusGoul HorusGoul self-assigned this Jul 21, 2021
@MelvinBot
MelvinBot requested review from madmax330 and removed request for a team July 21, 2021 12:02
@madmax330
madmax330 merged commit c9c2ee9 into main Jul 22, 2021
@madmax330
madmax330 deleted the horus-remove-notification-badge-icon branch July 22, 2021 09:30
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Jul 23, 2021
60 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging in version: 1.0.79-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production in version: 1.0.80-2🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants