Repository navigation
[CP Staging] Fix selection for splits when there is a search term present - #44505
Conversation
mountiny
left a comment
There was a problem hiding this comment.
LGTM, waiting for checklist
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-06-27.at.3.12.32.AM.movAndroid: mWeb ChromeScreen.Recording.2024-06-27.at.3.11.17.AM.moviOS: NativeScreen.Recording.2024-06-27.at.3.10.25.AM.moviOS: mWeb SafariScreen.Recording.2024-06-27.at.3.09.28.AM.movMacOS: Chrome / SafariScreen.Recording.2024-06-27.at.3.04.47.AM.movMacOS: DesktopScreen.Recording.2024-06-27.at.3.08.12.AM.mov |
This comment was marked as outdated.
This comment was marked as outdated.
|
@allroundexperts Yeah, or at least that is what happens on prod: Kapture.2024-06-26.at.15.14.14.mp4 |
|
@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Thanks! |
[CP Staging] Fix selection for splits when there is a search term present (cherry picked from commit 47fafdb)
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 9.0.2-2 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.3-7 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀
|
@suneox please review
Details
Fixes a split selection bug according to #44420 (comment)
Fixed Issues
$ #44420
PROPOSAL: #44420 (comment)
Tests/QA
Kapture.2024-06-26.at.13.25.52.mp4
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop