Repository navigation
Add parentReportActionID to iouReport - #44776
Conversation
f06dd8e to
60c39db
Compare
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Typescript check failure come from main branch |
Co-authored-by: Shubham Agrawal <58412969+shubham1206agra@users.noreply.github.com>
|
@shubham1206agra I just pushed new comment to adjust your comment |
|
@shubham1206agra Hi, Is there any problem with my PR anymore? |
|
@cretadn22 No, I will review this today. |
|
@cretadn22 Update main please |
|
@shubham1206agra It is Ok now |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeScreen.Recording.2024-07-18.at.10.38.02.PM.moviOS: NativeScreen.Recording.2024-07-18.at.10.49.59.PM.moviOS: mWeb SafariScreen.Recording.2024-07-18.at.10.30.29.PM.movMacOS: Chrome / SafariScreen.Recording.2024-07-18.at.6.44.36.PM.movMacOS: DesktopScreen.Recording.2024-07-18.at.10.43.43.PM.mov |
|
🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.0.10-2 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.10-3 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.0.10-7 🚀
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.0.11-5 🚀
|
Details
Add parentReportActionID to iouReport
Fixed Issues
$ #43582
PROPOSAL: #43582 (comment)
Tests
QA steps
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2024-07-04.at.09.07.35.mov
Android: mWeb Chrome
Screen.Recording.2024-07-04.at.09.03.43.mov
iOS: Native
Screen.Recording.2024-07-04.at.09.05.51.mov
iOS: mWeb Safari
Screen.Recording.2024-07-04.at.09.01.29.mov
MacOS: Chrome / Safari
Ghi-Man-hinh-2024-07-04-luc-07.59.58.mp4
MacOS: Desktop
1.mp4