Repository navigation
Add filters button - #47931
Add filters button#47931
Conversation
|
@rayane-djouah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
We need to add conditional rendering for textComponent in Button component here:
App/src/components/Button/index.tsx
Line 269 in 00a0b23
{!!text && textComponent}This is to make the filters icon centered on narrow layout on iOS and Android native apps.
Before:
After:
|
Updated! |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-08-23.at.8.38.52.PM.movAndroid: mWeb ChromeScreen.Recording.2024-08-23.at.8.37.57.PM.moviOS: NativeSimulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-08-23.at.20.37.01.mp4iOS: mWeb SafariSimulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-08-23.at.20.36.27.mp4MacOS: Chrome / SafariScreen.Recording.2024-08-23.at.8.35.14.PM.movMacOS: DesktopScreen.Recording.2024-08-23.at.8.38.32.PM.mov |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
|
The performance issue above was caused by another PR (#46645) and we have a fix here (#47891). Until that fix is merged, every new PR will post the performance regression message, see https://expensify.slack.com/archives/C05LX9D6E07/p1724453156193479 |
|
🚀 Deployed to staging by https://github.com/blimpich in version: 9.0.25-0 🚀
|
1 similar comment
|
🚀 Deployed to staging by https://github.com/blimpich in version: 9.0.25-0 🚀
|
|
This PR was deployed to prod in v9.0.26 |
Details
Adds a filters button to the search page which navigates users to the filters page
Fixed Issues
$ #47932
Tests
Filterspage opensOffline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
chrome.mov
iOS: Native
ios.mov
iOS: mWeb Safari
safari.mov
MacOS: Chrome / Safari
MacOS: Desktop