Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,7 @@ jobs:
env:
GITHUB_TOKEN: ${{ github.token }}

- name: Warn deployers if staging deploy failed
- name: Warn deployers if staging GH prerelease failed
if: ${{ failure() }}
uses: 8398a7/action-slack@v3
with:
Expand All @@ -535,7 +535,7 @@ jobs:
attachments: [{
color: "#DB4545",
pretext: `<!subteam^S4TJJ3PSL>`,
text: `💥 NewDot staging deploy failed. 💥`,
text: `💥 NewDot staging GH prerelease failed. 💥`,
}]
}
env:
Expand All @@ -562,7 +562,8 @@ jobs:
./desktop-build-artifact/NewExpensify.dmg \
./web-sourcemaps-artifact/web-merged-source-map.js.map#web-sourcemap-${{ needs.prep.outputs.APP_VERSION }} \
./web-build-tar-gz-artifact/webBuild.tar.gz \
./web-build-zip-artifact/webBuild.zip
./web-build-zip-artifact/webBuild.zip \
--clobber
env:
GITHUB_TOKEN: ${{ github.token }}

Expand All @@ -574,7 +575,7 @@ jobs:
env:
GITHUB_TOKEN: ${{ github.token }}

- name: Warn deployers if production deploy failed
- name: Warn deployers if production GH release failed
if: ${{ failure() }}
uses: 8398a7/action-slack@v3
with:
Expand All @@ -585,7 +586,7 @@ jobs:
attachments: [{
color: "#DB4545",
pretext: `<!subteam^S4TJJ3PSL>`,
text: `💥 NewDot production deploy failed. 💥`,
text: `💥 NewDot production GH release failed. 💥`,
}]
}
env:
Expand All @@ -595,7 +596,7 @@ jobs:
postSlackMessageOnSuccess:
name: Post a Slack message when all platforms deploy successfully
runs-on: ubuntu-latest
if: ${{ fromJSON(needs.checkDeploymentSuccess.outputs.IS_ALL_PLATFORMS_DEPLOYED) }}
if: ${{ always() && fromJSON(needs.checkDeploymentSuccess.outputs.IS_ALL_PLATFORMS_DEPLOYED) }}
needs: [prep, checkDeploymentSuccess, createPrerelease, finalizeRelease]
steps:
- name: 'Announces the deploy in the #announce Slack room'
Expand Down Expand Up @@ -651,7 +652,7 @@ jobs:
name: Post a GitHub comments on all deployed PRs when platforms are done building and deploying
runs-on: ubuntu-latest
if: ${{ always() && fromJSON(needs.checkDeploymentSuccess.outputs.IS_AT_LEAST_ONE_PLATFORM_DEPLOYED) }}
needs: [prep, android, desktop, iOS, web, checkDeploymentSuccess, createPrerelease, finalizeRelease]
needs: [prep, android, desktop, iOS, web, checkDeploymentSuccess]
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down