Skip to content

Revert "fix: ProfileAvatar (modal) page has no slide in animation" - #53784

Merged
luacmartins merged 1 commit into
Expensify:mainfrom
ishpaul777:revert-53475-@chrispader/fix-attachment-modal-screens-open-animation
Dec 9, 2024
Merged

luacmartins merged 1 commit into
Expensify:mainfrom
ishpaul777:revert-53475-@chrispader/fix-attachment-modal-screens-open-animation

Conversation

@ishpaul777

@ishpaul777 ishpaul777 commented Dec 9, 2024 •

Copy link
Copy Markdown
Contributor

Reverts #53475

Fixed issues:
$ #53777
$ #53772
$ #53780

@ishpaul777
ishpaul777 marked this pull request as ready for review December 9, 2024 20:45
@ishpaul777
ishpaul777 requested a review from a team as a code owner December 9, 2024 20:45
@melvin-bot
melvin-bot Bot requested review from mjasikowski and removed request for a team December 9, 2024 20:45
@melvin-bot

melvin-bot Bot commented Dec 9, 2024

Copy link
Copy Markdown

@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@luacmartins

Copy link
Copy Markdown
Contributor

Merging since it's a straight revert

@luacmartins
luacmartins merged commit 06abff8 into Expensify:main Dec 9, 2024
@melvin-bot

melvin-bot Bot commented Dec 9, 2024

Copy link
Copy Markdown

@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot Bot added the Emergency label Dec 9, 2024
@luacmartins

Copy link
Copy Markdown
Contributor

Straight revert, not an emergency

@OSBotify

OSBotify commented Dec 9, 2024

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Dec 9, 2024
…x-attachment-modal-screens-open-animation

Revert "fix: ProfileAvatar (modal) page has no slide in animation"

(cherry picked from commit 06abff8)

(CP triggered by luacmartins)
@github-actions github-actions Bot added the CP Staging marks PRs that have been CP'd to staging label Dec 9, 2024
@github-actions github-actions Bot mentioned this pull request Dec 9, 2024
70 tasks done
@github-actions

github-actions Bot commented Dec 9, 2024

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.0.73-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.73-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants