Skip to content

Allow failed image/receipt uploads to be retried - #54551

Merged
justinpersaud merged 41 commits into
Expensify:mainfrom
nyomanjyotisa:issue-50507-2
Mar 24, 2025
Merged

justinpersaud merged 41 commits into
Expensify:mainfrom
nyomanjyotisa:issue-50507-2

Conversation

@nyomanjyotisa

@nyomanjyotisa nyomanjyotisa commented Dec 25, 2024 •

Copy link
Copy Markdown
Member

Explanation of Change

Fixed Issues

$ #50507
PROPOSAL: #50507 (comment)

Tests

Same as QA Steps

  • Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Test 1 (Replace Receipt):

  1. Create an expense to a workspace or another user
  2. Turn on 'Simulate failing network requests'
  3. Replace and upload a new image for the receipt
  4. Verify that the receipt upload failed and display the error message: "There was an error uploading your receipt. Please try again or save the receipt to upload later."
  5. Dismiss the receipt
  6. Verify that the confirmation modal appears with the text: "Heads up! Dismissing this error will remove your uploaded receipt entirely. Are you sure?"
  7. Click on "Dismiss"
  8. Turn off the 'Simulate failing network requests'
  9. Go to Settings -> Troubleshoot -> Clear cache and restart
  10. Repeat steps 2-4
  11. Click on "save the file"
  12. Verify that the image file is downloaded and the error message dismissed
  13. Repeat steps 8-9 and then steps 2-4
  14. Turn off the 'Simulate failing network requests'
  15. Click on "try again"
  16. Verify that the image uploads successfully

Test 2 (Split Expense):

  1. Turn on 'Simulate failing network requests'
  2. Split an expense to a workspace
  3. Verify that the receipt upload failed and display the error message: "There was an error uploading your receipt. Please try again or save the receipt to upload later."
  4. Dismiss the receipt
  5. Verify that the confirmation modal appears with the text: "Heads up! Dismissing this error will remove your uploaded receipt entirely. Are you sure?"
  6. Click on "Dismiss"
  7. Turn off the 'Simulate failing network requests'
  8. Go to Settings -> Troubleshoot -> Clear cache and restart
  9. Repeat steps 1-3
  10. Click on "save the file"
  11. Verify that the image file is downloaded and the error message dismissed
  12. Repeat steps 7-8 and then steps 1-3
  13. Turn off the 'Simulate failing network requests'
  14. Click on "try again"
  15. Verify that the receipt uploads successfully.

Test 3 (Track Expense):

  1. Turn on 'Simulate failing network requests'
  2. Track an expense to a self DM
  3. Verify that the receipt upload failed and display the error message: "There was an error uploading your receipt. Please try again or save the receipt to upload later."
  4. Dismiss the receipt
  5. Verify that the confirmation modal appears with the text: "Heads up! Dismissing this error will remove your uploaded receipt entirely. Are you sure?"
  6. Click on "Dismiss"
  7. Turn off the 'Simulate failing network requests'
  8. Go to Settings -> Troubleshoot -> Clear cache and restart
  9. Repeat steps 1-3
  10. Click on "save the file"
  11. Verify that the image file is downloaded and the error message dismissed
  12. Repeat steps 7-8 and then steps 1-3
  13. Turn off the 'Simulate failing network requests'
  14. Click on "try again"
  15. Verify that the receipt uploads successfully.

Test 4 (Request Money - Scan):

Precondition

  • Workspace has at least one expense (request money)
  1. Turn on 'Simulate failing network requests'
  2. Create an expense to a workspace with a Receipt Scan
  3. Verify that the receipt upload failed and display the error message: "There was an error uploading your receipt. Please try again or save the receipt to upload later."
  4. Dismiss the receipt
  5. Verify that the confirmation modal appears with the text: "Heads up! Dismissing this error will remove your uploaded receipt entirely. Are you sure?"
  6. Click on "Dismiss"
  7. Turn off the 'Simulate failing network requests'
  8. Go to Settings -> Troubleshoot -> Clear cache and restart
  9. Repeat steps 1-3
  10. Click on "save the file"
  11. Verify that the image file is downloaded and the error message dismissed
  12. Repeat steps 7-8 and then steps 1-3
  13. Turn off the 'Simulate failing network requests'
  14. Click on "try again"
  15. Verify that the receipt uploads successfully.

Test 5 (Request Money - Manual):

  1. Turn on 'Simulate failing network requests'
  2. Manually create an expense to a workspace
  3. Verify that the expense creation fails and display the generic error message: "Unexpected error submitting this expense. Please try again later."
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android-Native.mp4
Android: mWeb Chrome
Android-mWeb.Chrome.mp4
iOS: Native
iOS-Native.mp4
iOS: mWeb Safari
iOS-mWeb.Safari.mp4
MacOS: Chrome / Safari
MacOS-Chrome.mp4
MacOS: Desktop
MacOS-Desktop.mp4

@nyomanjyotisa

nyomanjyotisa commented Dec 27, 2024 •

Copy link
Copy Markdown
Member Author

After checking again, there is a new issue on Android Native where the "Try Again" feature causes the receipt to appear uploaded in the app but fails during the actual upload process. This likely happens because the receipt is currently stored in the Downloads directory, and native Android cannot fetch images stored outside the app's private sandbox.

image

I think we need to explore an alternative approach for fetching images on Android. Still looking for a possible fix
This issue did not happen on the old PR because the change merged after I raised the PR

cc @dukenv0307 @sakluger

Android-Native.mp4

@dukenv0307

Copy link
Copy Markdown
Contributor

@nyomanjyotisa Have you found the solution?

@nyomanjyotisa

Copy link
Copy Markdown
Member Author

Yes, the issue on Android Native has been resolved

@nyomanjyotisa
nyomanjyotisa marked this pull request as ready for review January 2, 2025 06:00
@nyomanjyotisa
nyomanjyotisa requested a review from a team as a code owner January 2, 2025 06:00
@melvin-bot
melvin-bot Bot requested review from dukenv0307 and removed request for a team January 2, 2025 06:00
@melvin-bot

melvin-bot Bot commented Jan 2, 2025

Copy link
Copy Markdown

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@dukenv0307

dukenv0307 commented Jan 3, 2025 •

Copy link
Copy Markdown
Contributor

@nyomanjyotisa What about this place:

errors: getReceiptError(transaction.receipt, transaction.filename || transaction.receipt?.filename, false, errorKey),
? Do we need to add action and retryParams?

Comment thread src/libs/actions/IOU.ts Outdated
filename?: string,
isScanRequest = true,
errorKey?: number,
action?: string,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should defined the action enum here

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR updated

Comment thread src/libs/actions/IOU.ts Outdated
return isEmptyObject(receipt) || !isScanRequest
? ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('iou.error.genericCreateFailureMessage', errorKey)
: ErrorUtils.getMicroSecondOnyxErrorObject({error: CONST.IOU.RECEIPT_ERROR, source: receipt.source?.toString() ?? '', filename: filename ?? ''}, errorKey);
: ErrorUtils.getMicroSecondOnyxErrorObject(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case users manually request money within receipt, the isScanRequest will be false, so the receipt error will not added to failureData. IMO, isEmptyObject(receipt) is enough, but not sure why the author add !isScanRequest check. Can you check this case?

@nyomanjyotisa nyomanjyotisa Jan 6, 2025 •

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, isEmptyObject(receipt) should be enough in this case. I’m not entirely sure why that additional check was included either. If I remove the !isScanRequest condition, this line will cause the generic error to display, resulting in a duplicate error message.

image

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can you show these messages? I can't reproduce on my side

Screen.Recording.2025-01-06.at.11.18.41.mov

I think this line doesn't relate to isScanRequest. No matter what isScanRequest is, this error message is still added.

@dukenv0307 dukenv0307 Jan 6, 2025 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nyomanjyotisa But I think it's expected not to show receipt error in case manual request. So we should update the test steps.

For manual request: Show the generic message
For receipt request: Show the image error message

Comment thread src/libs/actions/IOU.ts
},
});

type StartSplitBilActionParams = {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we will refactor the params in this issue so we shouldn't create the new type in this PR.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that’s the case, how would you suggest handling retryParams in getReceiptError without introducing a new parameter like StartSplitBillActionParams? I believe the parameters haven’t been fully addressed in the mentioned issue yet right?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, you didn't introdude the new StartSplitBilActionParams, you just moved it to other place. So it's fine

@dukenv0307

Copy link
Copy Markdown
Contributor

I tested the retry and download feature on web and safari, they worked well but need to wait for @nyomanjyotisa to resolve the above comments before completing the tests on other platforms

@nyomanjyotisa

Copy link
Copy Markdown
Member Author

Do we need to add action and retryParams?

Correct me if I'm wrong, but I don't think action and retryParams are necessary there since the invoice doesn’t include a receipt

@dukenv0307

Copy link
Copy Markdown
Contributor

Correct me if I'm wrong, but I don't think action and retryParams are necessary there since the invoice doesn’t include a receipt

Yah, so I think we don't need to add retryParams here

@dukenv0307

Copy link
Copy Markdown
Contributor

@nyomanjyotisa Some tests are failed, can you pls check?

@nyomanjyotisa

Copy link
Copy Markdown
Member Author

Sorry for the late response. The failed test has been solved @dukenv0307

@dukenv0307

Copy link
Copy Markdown
Contributor

Reviewing...

Comment thread src/components/DotIndicatorMessage.tsx Outdated
? (JSON.parse(message.retryParams) as IOU.ReplaceReceipt | IOU.StartSplitBilActionParams | IOU.TrackExpense | IOU.RequestMoneyInformation)
: message.retryParams;

switch (message.action) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use ACTION_PARAMS const

Comment thread src/components/DotIndicatorMessage.tsx Outdated
<Text style={[StyleUtils.getDotIndicatorTextStyles(isErrorMessage)]}>{Localize.translateLocal('iou.error.receiptFailureMessage')}</Text>
<TextLink
style={[StyleUtils.getDotIndicatorTextStyles(), styles.link]}
onPress={() => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you pls define the new function for it (instead of anonymous func) ?

@justinpersaud

Copy link
Copy Markdown
Contributor

bump @kavimuru could you test using the suggestion @nyomanjyotisa provided above?

@dukenv0307

Copy link
Copy Markdown
Contributor

@kavimuru any updates?

@justinpersaud

Copy link
Copy Markdown
Contributor

@kavimuru

Copy link
Copy Markdown

Test 1 (Replace Receipt):
In last step still display waiting for submit expense for a long time .
Test 2 (Split expense):
while run step 7 , error message not shown up even waiting for 4 min.
Test 3 (Track expense):
while run step 7 , error message not shown up even waiting for 4 min.
Test 4 (Request Money - Scan):
while run step 7 , error message displayed "Unexpected error submitting this expense. Please try again later." .
while try to run step7 again , error message not shown up,

Screen.Recording.20250311.215139.New.Expensify.Adhoc.mp4
2025-03-11.10.20.47.PM.mp4
Test.1.Replace.Receipt.part.2.mp4
Test.1.Replace.Receipt.part.1.mp4
2025-03-11.10.09.35.PM.mp4

@dukenv0307

Copy link
Copy Markdown
Contributor

@nyomanjyotisa Can you please resolve the conflicts and check the above issues?

@nyomanjyotisa

Copy link
Copy Markdown
Member Author

I think the issues mentioned above are caused by the behavior of 'Simulate failing network requests'. When we use it instead of blocking the network request URL, the upload is actually not failing. Even if the user dismisses the error (the new receipt should not be uploaded), the receipt was actually uploaded. We can see the uploaded receipt after clearing the cache and restarting the app. Here is the detail:

New-Expensify.mp4

However, if we want to test the functionality of the 'try again', 'save', and 'dismiss' buttons, we can change the test steps to something like this:

Test 1

Test 1 (Replace Receipt):

  1. Create an expense to a workspace or another user
  2. Turn on 'Simulate failing network requests'
  3. Replace and upload a new image for the receipt
  4. Verify that the receipt upload failed and display the error message: "There was an error uploading your receipt. Please try again or save the receipt to upload later."
  5. Dismiss the receipt
  6. Verify that the confirmation modal appears with the text: "Heads up! Dismissing this error will remove your uploaded receipt entirely. Are you sure?"
  7. Click on "Dismiss"
  8. Turn off the 'Simulate failing network requests'
  9. Go to Settings -> Troubleshoot -> Clear cache and restart
  10. Repeat steps 2-4
  11. Click on "save the file"
  12. Verify that the image file is downloaded and the error message dismissed
  13. Repeat steps 8-9 and then steps 2-4
  14. Turn off the 'Simulate failing network requests'
  15. Click on "try again"
  16. Verify that the image uploads successfully
Replace-Receipt.mp4
Test 2

Test 2 (Split expense):

  1. Turn on 'Simulate failing network requests'
  2. Split an expense to a workspace
  3. Verify that the receipt upload failed and display the error message: "There was an error uploading your receipt. Please try again or save the receipt to upload later."
  4. Dismiss the receipt
  5. Verify that the confirmation modal appears with the text: "Heads up! Dismissing this error will remove your uploaded receipt entirely. Are you sure?"
  6. Click on "Dismiss"
  7. Turn off the 'Simulate failing network requests'
  8. Go to Settings -> Troubleshoot -> Clear cache and restart
  9. Repeat steps 1-3
  10. Click on "save the file"
  11. Verify that the image file is downloaded and the error message dismissed
  12. Repeat steps 7-8 and then steps 1-3
  13. Turn off the 'Simulate failing network requests'
  14. Click on "try again"
  15. Verify that the receipt uploads successfully.
Split-Expense.mp4
Test 3

Test 3 (Track Expense):

  1. Turn on 'Simulate failing network requests'
  2. Track an expense to a self DM
  3. Verify that the receipt upload failed and display the error message: "There was an error uploading your receipt. Please try again or save the receipt to upload later."
  4. Dismiss the receipt
  5. Verify that the confirmation modal appears with the text: "Heads up! Dismissing this error will remove your uploaded receipt entirely. Are you sure?"
  6. Click on "Dismiss"
  7. Turn off the 'Simulate failing network requests'
  8. Go to Settings -> Troubleshoot -> Clear cache and restart
  9. Repeat steps 1-3
  10. Click on "save the file"
  11. Verify that the image file is downloaded and the error message dismissed
  12. Repeat steps 7-8 and then steps 1-3
  13. Turn off the 'Simulate failing network requests'
  14. Click on "try again"
  15. Verify that the receipt uploads successfully.
Track-Expense.mp4
Test 4

Test 4 (Request Money - Scan):

Precondition

  • Workspace has at least one expense (request money)
  1. Turn on 'Simulate failing network requests'
  2. Create an expense to a workspace with a Receipt Scan
  3. Verify that the receipt upload failed and display the error message: "There was an error uploading your receipt. Please try again or save the receipt to upload later."
  4. Dismiss the receipt
  5. Verify that the confirmation modal appears with the text: "Heads up! Dismissing this error will remove your uploaded receipt entirely. Are you sure?"
  6. Click on "Dismiss"
  7. Turn off the 'Simulate failing network requests'
  8. Go to Settings -> Troubleshoot -> Clear cache and restart
  9. Repeat steps 1-3
  10. Click on "save the file"
  11. Verify that the image file is downloaded and the error message dismissed
  12. Repeat steps 7-8 and then steps 1-3
  13. Turn off the 'Simulate failing network requests'
  14. Click on "try again"
  15. Verify that the receipt uploads successfully.
Request-Money.mp4

Please note that four new expenses will be created for tests 2, 3, and 4 because when we dismiss or save the receipt, the expenses are actually created instead of being dismissed (due to the 'Simulate failing network requests' behavior). Additionally, when we click on 'try again', two expenses will be created since 'try again' calls the API to create the expense again

What do you think? Should we change the test steps? @dukenv0307

@dukenv0307

Copy link
Copy Markdown
Contributor

@nyomanjyotisa Yes, please

@dukenv0307

Copy link
Copy Markdown
Contributor

@kavimuru Can you please check again? We should merge this PR soon

@kavimuru

Copy link
Copy Markdown

Android:
Passed all the steps
Web:
Test 2: Fail (Turn off the ‘Simulate failing network requests’ then click ‘Try again’ but the error message is not dismissed)

test.2-.Fail.mp4

Desktop:
Test3 : Fail (self dm disappears)

test3-fail.self.dm.disappears.mp4

iOS and mweb tests are pending

@nyomanjyotisa

Copy link
Copy Markdown
Member Author

I don't think the code is failing since I can’t reproduce the same error on the web for split expense or on the desktop for track expense. Could you please confirm this on your side? @dukenv0307

Web (Test 2)

MacOS-Chrome.mp4

Desktop (Test 3)

MacOS-Desktop.mp4

@dukenv0307

Copy link
Copy Markdown
Contributor

@kavimuru @nyomanjyotisa I also can't reproduce, all tests passed on my side

web-resize.mp4
Screen.Recording.2025-03-19.at.10.51.33.mov

@justinpersaud

Copy link
Copy Markdown
Contributor

It seems to work for me too. I think we can move forward then. Looks like we need a rebease again and then do final reviews.

@nyomanjyotisa

Copy link
Copy Markdown
Member Author

PR updated

@melvin-bot
melvin-bot Bot requested a review from justinpersaud March 24, 2025 01:45
@justinpersaud
justinpersaud merged commit 7271528 into Expensify:main Mar 24, 2025
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions github-actions Bot mentioned this pull request Mar 24, 2025
48 tasks done
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/justinpersaud in version: 9.1.18-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 cancelled 🔪
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 cancelled 🔪
🍎🔄 iOS HybridApp 🍎🔄 cancelled 🔪

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/cristipaval in version: 9.1.18-4 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 failure ❌

let transactionID;
if (isMoneyRequestAction(action)) {
transactionID = getOriginalMessage(action)?.IOUTransactionID;
revert(transactionID, getLastModifiedExpense(reportID));

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coming from #59434, this change has caused a regression; we have to revert the transaction when the update request fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants