Repository navigation
[CP Staging] Fix illustration styling for empty view - #54577
Conversation
|
@paultsimura @ One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| <ScrollView contentContainerStyle={[styles.flex1, styles.justifyContentCenter]}> | ||
| <View style={[styles.overflowHidden, styles.minHeight65]}> |
There was a problem hiding this comment.
| <ScrollView contentContainerStyle={[styles.flex1, styles.justifyContentCenter]}> | |
| <View style={[styles.overflowHidden, styles.minHeight65]}> | |
| <ScrollView contentContainerStyle={[styles.flexGrow1]}> | |
| <View style={[styles.flex1, styles.overflowHidden, styles.minHeight65]}> |
Let's only add styles.flexGrow1 to the ScrollView bcoz flex1 won't show the scrollbar for native if content exceeds.
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-12-26.at.12.15.00.mp4
Co-authored-by: Pujan Shah <shahpujan1992@gmail.com>
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
[CP Staging] Fix illustration styling for empty view (cherry picked from commit d3afb19) (CP triggered by jasperhuangg)
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.0.78-4 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.78-6 🚀
|
Explanation of Change
Update styling
Fixed Issues
$ #54564
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
See MacOS: Chrome / SafariAndroid: mWeb Chrome
See MacOS: Chrome / SafariiOS: Native
See MacOS: Chrome / SafariiOS: mWeb Safari
See MacOS: Chrome / SafariMacOS: Chrome / Safari
MacOS: Desktop
See MacOS: Chrome / Safari