Skip to content

Revert "fix: when selecting categories, the selected categories get reset" - #54583

Merged
neil-marcellini merged 1 commit into
mainfrom
revert-53519-fix-49322
Dec 26, 2024
Merged

neil-marcellini merged 1 commit into
mainfrom
revert-53519-fix-49322

Conversation

@neil-marcellini

Copy link
Copy Markdown
Contributor

Explanation of change

Reverts #53519 to fix #54486. The PR we're reverting uncovered that issue. There's probably a better way to fix the original issue that PR aimed to solve, without causing this bug.

Fixed Issues

$ #54486

@neil-marcellini neil-marcellini self-assigned this Dec 26, 2024
@neil-marcellini
neil-marcellini requested a review from a team as a code owner December 26, 2024 17:45
@neil-marcellini
neil-marcellini requested review from jasperhuangg and removed request for a team December 26, 2024 17:45
@melvin-bot
melvin-bot Bot requested a review from MarioExpensify December 26, 2024 17:45
@melvin-bot

melvin-bot Bot commented Dec 26, 2024

Copy link
Copy Markdown

@MarioExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@neil-marcellini
neil-marcellini merged commit 56e35ce into main Dec 26, 2024
@neil-marcellini
neil-marcellini deleted the revert-53519-fix-49322 branch December 26, 2024 17:47
@melvin-bot melvin-bot Bot added the Emergency label Dec 26, 2024
@melvin-bot

melvin-bot Bot commented Dec 26, 2024

Copy link
Copy Markdown

@neil-marcellini looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@neil-marcellini

Copy link
Copy Markdown
Contributor Author

Straight revert so no need for checklists

OSBotify pushed a commit that referenced this pull request Dec 26, 2024
Revert "fix: when selecting categories, the selected categories get reset"

(cherry picked from commit 56e35ce)

(CP triggered by AndrewGable)
@github-actions github-actions Bot added the CP Staging marks PRs that have been CP'd to staging label Dec 26, 2024
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 9.0.78-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.78-6 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Category - Selected item is no longer selected after renaming the category

3 participants