Repository navigation
Remove 'presence-activeGuides' pusher channel - #58668
Merged
Merged
Conversation
aldo-expensify
marked this pull request as ready for review
March 18, 2025 23:38
Contributor
Author
|
@MonilBhavsar or @grgia can you add the Reviewer checklist 🙏 |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
Author
|
Thanks @MonilBhavsar ! |
48 tasks done
Contributor
|
🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.1.18-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.1.18-4 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
The
presence-activeGuideschannel was removed in this PR: https://github.com/Expensify/Web-Expensify/pull/45887/files, we need to remove this from the App, otherwise, the App will try to use the channel and we will create server errors.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/482071#issuecomment-2734593707
PROPOSAL:
Tests
Onyx.merge('user', {isGuide: true})AuthenticatePusherrequest with aInvalid Channel Name: activeGuideerror:presence-activeGuide:Offline tests
QA Steps
Onyx.merge('user', {isGuide: true})AuthenticatePusherrequest with aInvalid Channel Name: activeGuideerror:presence-activeGuide:PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop