Repository navigation
[WebRTC] Make a call to AI SDR (Sales & development representative) - #58867
Conversation
|
|
|
|
|
@rushatgabhane do you have an ETA? I'd love to see this in product on Monday, if possible. |
|
|
|
|
|
|
|
|
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@quinthar this is ready for review. We might have to iron a few things out, Jack is helping me with that!! : ) slack thread here https://expensify.slack.com/archives/C02NK2DQWUX/p1742493503029749 |
|
|
|
|
Co-authored-by: DylanDylann <141406735+DylanDylann@users.noreply.github.com>
|
|
not necessary now. get token is the longest call and we have a default timeout because it uses API util |
|
|
| @@ -0,0 +1,257 @@ | |||
| /* eslint-disable @typescript-eslint/no-unsafe-member-access */ | |||
There was a problem hiding this comment.
we can get rid of this once we support typescript for webrtc-web-shim
Reviewer Checklist
Screenshots/VideosiOS: mWeb SafariIMG_1044.mp4MacOS: Chrome / SafariScreen.Recording.2025-03-24.at.12.34.31.mov |
|
@rushatgabhane SendRecapInAdminsRoom will not be called if we proactively turn off the connection by clicking "Hang Up" button. Is this intentional? |
|
Let's see this below test: AI agents: Hello h........... Stopping a bit AI agents: You're welcome............... Screen.Recording.2025-03-24.at.12.34.31.movAI agents should talk more smoothly. I think this problem is caused by we send a greeting message and when AI agents receive this greeting message they start again |
|
On mobile safari, I also don't see a new message from Concierge after ending the call IMG_1044.mp4 |
|
@thienlnam @rushatgabhane In general, the PR works fine. There. are only some above minor problems. I am fine if we can merge this PR soon and make a follow-up later |
|
Thanks for the quick review here, the above should be fine - we're more looking to explore this solution behind beta for now and can clean up those things later |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/thienlnam in version: 9.1.18-0 🚀
|
|
Hi 👋 I noticed some changes in
Would be nice if you could run @DylanDylann it would probably be required to do the same in Mobile-Expensify repo |
|
@rushatgabhane please note to include the above things in the next PR |
|
I noticed that this PR introduced |
There was a problem hiding this comment.
@rushatgabhane Could you add types.ts, so there is one single source of truth? From our guidelines:
### File organization
In modules with platform-specific implementations, create `types.ts` to define shared types. Import and use shared types in each platform specific files. Do not use [`satisfies` operator](#satisfies-operator) for platform-specific implementations, always define shared types that complies with all variants.NAB: index.ts is usually the implementation for web, while this file could be renamed to index.native.ts
We're not committing to keeping these libraries, this is gated behind a beta so PMs can evaluate the solution. If we decide to move forward, I agree it should go through the usual process, and I'll kick off those conversations. But given we might rip this out entirely, we didn’t want to invest in the full process prematurely. |
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.1.18-4 🚀
|


Explanation of Change
Fixed Issues
$ #58780
PROPOSAL:
Screenshots/Videos
Screen.Recording.2025-03-22.at.04.44.03.mov
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.