Repository navigation
[CP Staging] Fix Unable to dismiss keyboard by tapping outside the message field - #59067
Conversation
|
🚧 @grgia has triggered a test app build. You can view the workflow run here. |
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen_Recording_20250325_221141_New.Expensify.AdHoc.mp4Android: mWeb ChromeiOS: NativeScreenRecording_03-25-2025.20-55-13_1.MP4iOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
…eyboard-not-dismissing Fix Unable to dismiss keyboard by tapping outside the message field (cherry picked from commit 7b70593) (CP triggered by cristipaval)
|
🚀 Cherry-picked to staging by https://github.com/cristipaval in version: 9.1.18-4 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
Issue seem to be resolved, but Some ANDROID devices need couple times to tap to close the keyboard. Seem intermittent, but posting here in case Should we log a different issue? 2025-03-26.7.40.56.AM.mp4 |
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.1.18-4 🚀
|
Explanation of Change
This pr fixes linked issues. It adds keyboard dismiss on press and extends mime type list to handle sharing videos from android gallery
Fixed Issues
$ #59030
$ #59025
PROPOSAL:
Tests
Share video from android gallery (make sure that the extension is supported e.g. mp4)
Verify that no error appears
click
sharetabVerify that keyboard can be dismissed by clicking outside of the input area
Share file on iOS and repeat steps 3-4
Offline tests
QA Steps
same as tests
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-03-25.at.17.56.25.mov
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop