Repository navigation
Fix capitalization - #60734
Fix capitalization#60734
Conversation
|
@rayane-d PR is up for review. Also do you think we could mark this as a [NO-QA] pr? |
|
@rayane-d PR is ready for review. |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb Safari |
|
@rayane-d you could make use of console command for easy reproduction(or maybe add it somewhere in useEffect). Onyx.set('transactionViolations_8186437731154618998',[{name:'prohibitedExpense',data:{prohibitedExpenseRule:'adultEntertainment'},showInReview:true,type:'violation'}]) |
|
Thanks @ChavdaSachin! The message in "MacOS: Desktop" and "Android: mWeb Chrome" sections of your provided screenshots does not have correct capitalization. Can you please fix them? Can you please also remove the extra white space in the Spanish translation file?
I think the QA steps look good and this doesn't have to be marked as no QA. |
|
@ChavdaSachin Let's specify in the QA steps that access to
|
|
@rayane-d Updated Spanish file, SS and QA steps. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/dangrous in version: 9.1.38-0 🚀
|
|
🚀 Deployed to production by https://github.com/thienlnam in version: 9.1.38-4 🚀
|


Explanation of Change
Fixed the capitalization, removed the extra white space.
Fixed Issues
$ #60216
PROPOSAL: #60216 (comment)
Tests
same as QA
Offline tests
same as QA
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
receiptLineItemsbetaNote
A few console errors related to
canBeMissingare present, but they are irrelevant to this PR.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop