Repository navigation
Consider Attendee Tracking enabled by default for existing Corporate policies - #63520
Merged
Merged
Conversation
…cies Policies that existed before attendee tracking was made a feature don't have the `isAttendeeTrackingEnabled` flag. This makes it so we'll assume the feature is on by default, until it's explicitly turned off.
francoisl
force-pushed
the
francois-attendee-tracking-defaults
branch
from
June 5, 2025 04:39
8f5f274 to
88898b2
Compare
francoisl
marked this pull request as ready for review
June 5, 2025 05:20
Contributor
Author
|
I merged main and tests are passing now. |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
77 tasks done
Contributor
|
🚀 Deployed to staging by https://github.com/mollfpr in version: 9.1.63-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.1.63-6 🚀
|
1 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
On Expensify Classic, attendee tracking wasn't a feature you could disable like you can now on NewDot, so it was "always on", in a way. Thus, people migrating from Classic to NewDot might be confused if they no longer see the feature, and don't know they need to manually enable it.
This changes the default behavior for how we determine if Attendee Tracking should be enabled or disabled like so:
isAttendeeTrackingEnabled:Fixed Issues
Part of #63464
Tests
Same as QA
Offline tests
Mostly the same as the QA steps, but some steps like upgrading a workspace require being online, and are not testable.
QA Steps
Test 1: Existing control workspace
Pre-requisite: have an account with an existing Corporate workspace
Test 2: new workspaces
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
Screen.Recording.2025-06-04.at.22.07.26.mov