Repository navigation
fix: iOS Hybrid - Native share - Switching between Submit and Share causes keyboard to lose focus. #63741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix: iOS Hybrid - Native share - Switching between Submit and Share causes keyboard to lose focus. #63741
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
54e2e68
fix: iOS Hybrid - Native share - Switching between Submit and Share c…
Krishna2323 a079969
Merge branch 'main' into krishna2323/issue/62206
Krishna2323 d68e95b
fix merge conflicts.
Krishna2323 eaa96d9
Merge branch 'Expensify:main' into krishna2323/issue/62206
Krishna2323 af4f8e3
use same approach as in NewChatSelectorPage component to focus on inp…
Krishna2323 f3327be
Merge branch 'main' into krishna2323/issue/62206
Krishna2323 969d0b5
minor fix.
Krishna2323 e7aa433
Merge branch 'Expensify:main' into krishna2323/issue/62206
Krishna2323 bf06363
fix autoFocus in IOURequestStepParticipants.
Krishna2323 d753195
Merge branch 'main' into krishna2323/issue/62206
Krishna2323 fdb658e
fix ESLint.
Krishna2323 e467867
fix autofocus when modal is open.
Krishna2323 bcd32d1
Merge branch 'Expensify:main' into krishna2323/issue/62206
Krishna2323 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,19 @@ | ||
| import React from 'react'; | ||
| import React, {forwardRef} from 'react'; | ||
| import ShareTabParticipantsSelector from '@components/Share/ShareTabParticipantsSelector'; | ||
| import ROUTES from '@src/ROUTES'; | ||
|
|
||
| function SubmitTab() { | ||
| return <ShareTabParticipantsSelector detailsPageRouteObject={ROUTES.SHARE_SUBMIT_DETAILS} />; | ||
| type InputFocusRef = { | ||
| focus?: () => void; | ||
| }; | ||
|
|
||
| function SubmitTabComponent(_props: unknown, ref: React.Ref<InputFocusRef>) { | ||
| return ( | ||
| <ShareTabParticipantsSelector | ||
| ref={ref} | ||
| detailsPageRouteObject={ROUTES.SHARE_SUBMIT_DETAILS} | ||
| /> | ||
| ); | ||
| } | ||
|
|
||
| const SubmitTab = forwardRef(SubmitTabComponent); | ||
| export default SubmitTab; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line causes: #70626
More details:
#70626 (comment)