You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Update Terms and Fees step to match latest requirements - #6573
Looking pretty good! I forget where we landed with this general UX discussion, but should we actually move the green button to be at the very bottom of the disclosure text instead of being fixed to the bottom of the viewport? I think that makes sense given that you basically need to scroll all the way to the bottom and tap on the checkboxes before moving forward. Thoughts on that?
Not affected by this PR, but I think we should update the error message
Good find, I'll have a look
I forget where we landed with this general UX discussion, but should we actually move the green button to be at the very bottom of the disclosure text instead of being fixed to the bottom of the viewport?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @shawnborton for design 👀
Details
This PR updates the styles for the Terms and Fees step of the VBA flow based on the mockups in https://github.com/Expensify/Expensify/issues/167278#issuecomment-982972716.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/167278
Tests
The easiest way to get to the Terms Page without going through the entire OnFido flow is to update the following lines locally:
+button and selectingNew ChatQA Steps
No QA
Tested On
Screenshots