Repository navigation
Revert some changes for Fix splitted transactions don't show immediately - #66741
Conversation
|
@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Does this need a review from me? |
@luacmartins |
|
@allroundexperts yes, let's test this fixes the original issue and android doesn't crash |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-07-19.at.2.24.47.AM.movAndroid: mWeb ChromeScreen.Recording.2025-07-19.at.2.07.04.AM.moviOS: HybridAppScreen.Recording.2025-07-19.at.2.21.05.AM.moviOS: mWeb SafariScreen.Recording.2025-07-19.at.2.01.46.AM.movMacOS: Chrome / SafariScreen.Recording.2025-07-19.at.1.54.19.AM.movMacOS: DesktopScreen.Recording.2025-07-19.at.1.58.15.AM.mov |
|
@allroundexperts how's the review going? This is fixing a deploy blocker so there's some urgency on it |
|
Almost done. Apologies for the delay. I had to rebuild the apps to test this. |
…2-fix/64257-splitted-tx-doesnt-show-immediately Revert some changes for Fix splitted transactions don't show immediately (cherry picked from commit 577692f) (cherry-picked to staging by luacmartins)
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.1.83-4 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.1.83-5 🚀
|
Explanation of Change
Fixed Issues
$ #66690
PROPOSAL:
Tests
Tests
Offline tests
QA Steps
Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
2025-07-18.20.35.05.mov
Android: mWeb Chrome
2025-07-18.20.29.56.mov
iOS: Native
2025-07-18.21.05.17.mov
iOS: mWeb Safari
2025-07-18.20.37.17.mov
MacOS: Chrome / Safari
2025-07-18.20.26.30.mov
MacOS: Desktop
2025-07-18.20.26.30.mov