Repository navigation
Add some hitSlop around the send button - #6708
Conversation
| onPress={this.submitForm} | ||
| underlayColor={themeColors.componentBG} | ||
| disabled={this.state.isCommentEmpty || isBlockedFromConcierge || isArchivedChatRoom} | ||
| hitSlop={{top: 3, right: 3, bottom: 3, left: 3}} |
There was a problem hiding this comment.
The docs say that you should be able to pass a single number here, but that caused a crash when I tried it.
|
@deetergp I just fixed the lint errors here, ready for review |
| underlayColor={themeColors.componentBG} | ||
| disabled={this.state.isCommentEmpty || isBlockedFromConcierge || isArchivedChatRoom} | ||
| hitSlop={{ | ||
| top: 3, right: 3, bottom: 3, left: 3, |
There was a problem hiding this comment.
Note that 3 is chosen because it matches the margin around the button. That's the max hitSlop we can add because it cannot extend beyond the bounds of the parent component.
deetergp
left a comment
There was a problem hiding this comment.
It's silly that you have to send the same number four times, but the code looks good and test well.
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to production by @Julesssss in version: 1.1.21-1 🚀
|
Details
Adds some extra touchability margins around the "send chat" button.
Fixed Issues
$ #6662
Tests / QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android