Repository navigation
Expensify Card feed defaults to other workspace after enabling Expensify Card in other workspace - #67374
Conversation
|
@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@allroundexperts I'm not able to mock data new workspace card feed on native and ios safari. Could you please help me check it on? |
|
@allroundexperts are you able to help out with the testing here? |
|
Hey @dangrous! |
|
Okay thanks! and @thelullabyy were you able to review this proposal and see if there was anything useful we wanted to implement? |
|
Hi @thelullabyy! |
|
@allroundexperts Yup, i tested via |
|
@thelullabyy I'm getting the following even after executing your code. Screen.Recording.2025-08-06.at.1.00.09.PM.mov |
|
@thelullabyy I am seeing an issue of the Screen.Recording.2025-08-06.at.22.38.53.movI believe logically we should not update the selected card feed onyx every time when we visit WorkspaceExpensifyCard Page, instead it would be better if we correct the conditions. |
|
@allroundexperts I've already activated an Expensify CardFeed for current workspace long time ago. After that I run |
|
@Pujan92 My proposal updates card feed based on |
|
@thelullabyy still I don't get why to update that on page visit which we are specifically doing on card selector updation. To test, you can do the following steps
|
|
@Pujan92 I stuck on verify bank account step when issue new card. And can you clarify more why
|
I also faced this earlier, but using a different bank account id for both workspaces solved it for me.
As |
|
@Pujan92 Make sense to me. But will have any affect with my proposal since we decided to choose the simpler solution |
|
@allroundexperts Do you have any thought for this? |
|
@allroundexperts bump in this ^ |
|
@thelullabyy I am trying to get the workspace ready. Asking for help in the C+ channel. |
@thelullabyy have you checked this? Isn't that look more straightforward and correct? |
|
@Pujan92 Yeah but i'm not sure it cause regression or not. I would like to consult @allroundexperts |
|
@thelullabyy If you agree with the solution provided by @Pujan92, let's maybe use there solution and we split the compensation? |
|
I reviewed @Pujan92 ’s solution again, and I believe this is intentional rather than a mistake. The domain fundID should be different from the workspace accountID so that multiple funds within the same workspace can be distinguished. App/src/hooks/useDefaultFundID.ts Line 19 in b73ebe2 For my solution, I still align with it. Regarding this comment, we can add a check only to call cc @koko57 Because you are the author of this feature |
|
I don't remember mvery well but I don't agree with this one: If we didn't have this condition domainFundID would be the same as workspaceAccountID, right? I don't remember why we wanted to differentiate between them, but it was intentional like @thelullabyy says |
Ah, Ok. Thanks @thelullabyy and @koko57 for the info. Then I think we should change the order of condition bcoz I believe if (workspaceAccountID) {
return workspaceAccountID;
}
if (domainFundID) {
return domainFundID;
} |
I wonder why out of a sudden the IDs got mixed up with other workspaces? 🤔 If I understand correctly the whole issue. |
|
Hi @thelullabyy, I'll reach out to you tomorrow morning for the creds. |
|
@allroundexperts updated |
|
did we figure out how to test this one successfully @allroundexperts ? |
|
Replied in the slack thread @dangrous |
|
Seems like maybe we should re-add the same bank account, rather than using it again... Can you try that? Sort of weird, but if it works it works! |
|
Continuing the discussion in Slack, I'm having even less luck testing this than you are! |
|
Just an update, we're still waiting on a software fix from our card processors to let us test this (and everything else related to test cards) again. So this may be on hold for a while |
|
[Internal] Issue for the card thing that's blocking this is here - https://github.com/Expensify/Expensify/issues/555406#issuecomment-3625323372 |
|
@allroundexperts do you mind trying to test this one again? I believe the card issue has been fixed. If it's still not working for you, I can try as well! |
|
Bump on testing when you can, @allroundexperts! If you're still hitting that issue with the second account, I will try too, next week. |
It seems now the preferredPolicy looks correct and not set to a default workspace which I mentioned above earlier. Bcoz of that, feed selector won't be shown as we will have a single feed for any specific policy.
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
@dangrous To replicate the issue behavior, I modified the preferredPolicy in the Onyx expensifyCardSettings to get the FeedSelector in the screen. Current Screen.Recording.2025-12-24.at.02.39.39.movWith this PR Screen.Recording.2025-12-24.at.02.41.08.mov |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/dangrous in version: 9.2.88-0 🚀
|
|
This PR failing because of a regression issue |
|
@jponikarchuk that isn't a regression and same behaviour in prod too. @dangrous this is something I highlighted here |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.2.88-7 🚀
|
|
@Pujan92 You are right. This issue is reproducible in Prod too |



Explanation of Change
Fixed Issues
$#65593
PROPOSAL:#65593 (comment)
Tests
Precondition:
Offline tests
QA Steps
Precondition:
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
android_web.mov
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
chorme.mov
MacOS: Desktop
desktop.mov