Skip to content

Trim Login value before validating it on LoginForm - #6771

Merged
tgolen merged 1 commit into
Expensify:mainfrom
parasharrajat:trim-login
Dec 15, 2021
Merged

tgolen merged 1 commit into
Expensify:mainfrom
parasharrajat:trim-login

Conversation

@parasharrajat

@parasharrajat parasharrajat commented Dec 15, 2021 •

Copy link
Copy Markdown
Member

Details

Fixed Issues

$ #6694

Tests | QA Steps

  1. Go to Login page.
  2. Enter username email or phone and append space.
  3. press Continue.
  4. You should be taken to the password page.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop

output_file.mp4

Mobile Web

iOS

Android

@parasharrajat
parasharrajat requested a review from a team as a code owner December 15, 2021 13:08
@MelvinBot
MelvinBot requested review from tgolen and removed request for a team December 15, 2021 13:08
@tgolen
tgolen merged commit 354cb39 into Expensify:main Dec 15, 2021
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Dec 15, 2021
37 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @tgolen in version: 1.1.20-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @Julesssss in version: 1.1.21-1 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@parasharrajat
parasharrajat deleted the trim-login branch November 20, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants