Repository navigation
Refactor: Remove call to getReportNameValuePairs() in method getInvoiceChatByParticipants from ReportUtils.ts - #67911
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #67101
PROPOSAL:
Tests
Same as QA Steps
Offline tests
Same as QA steps
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Test 1
Precondition:
Test 2 (contiued from Test 1)
Test 3
Precondition:
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android.Screen.Recording.2025-07-28.at.4.02.32.in.the.afternoon.mp4
Android.Screen.Recording.2025-07-28.at.5.10.42.in.the.afternoon.mp4
android.Screen.Recording.2025-07-28.at.5.24.39.in.the.afternoon.mov
Android: mWeb Chrome
Android.chrome.Screen.Recording.2025-07-28.at.4.30.06.in.the.afternoon.mp4
Android.chrome.Screen.Recording.2025-07-28.at.5.07.39.in.the.afternoon.mp4
Android.chrome.Screen.Recording.2025-07-28.at.5.29.13.in.the.afternoon.mov
iOS: Native
ios.Screen.Recording.2025-07-28.at.3.45.21.in.the.afternoon.mp4
ios.Screen.Recording.2025-07-28.at.5.05.08.in.the.afternoon.mp4
ios.Screen.Recording.2025-07-28.at.5.32.19.in.the.afternoon.mov
iOS: mWeb Safari
ios.safari.Screen.Recording.2025-07-28.at.3.52.52.in.the.afternoon.mp4
safari.ios.Screen.Recording.2025-07-28.at.5.03.12.in.the.afternoon.mp4
ios.safari.Screen.Recording.2025-07-28.at.5.34.27.in.the.afternoon.mov
MacOS: Chrome / Safari
web.Screen.Recording.2025-07-28.at.3.41.01.in.the.afternoon.mp4
web.Screen.Recording.2025-07-28.at.4.59.36.in.the.afternoon.mp4
Web.Screen.Recording.2025-07-28.at.5.38.25.in.the.afternoon.mov
MacOS: Desktop
desktop.Screen.Recording.2025-07-28.at.4.50.42.in.the.afternoon.mp4
desktop.Screen.Recording.2025-07-28.at.4.56.49.in.the.afternoon.mp4
desktop.Screen.Recording.2025-07-28.at.5.36.26.in.the.afternoon.mov