Repository navigation
[HybridApp] Migrate to NewDot sign-in page #67996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Julesssss
merged 33 commits into
Expensify:main
from
software-mansion-labs:migrate-hybrid-app-to-new-dot-sign-in-page
Aug 25, 2025
Merged
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
0fe2021
remove HybridApp code from SessionExpiredPage & cleanup closeReactNat…
war-in f703298
revert unrelated changes
war-in bc97f82
fix prettier
war-in 088dd8c
Revert "[CP Staging] Revert "Bring back new SignInPage""
war-in 7e65b7e
create custom isAnonymousUser function
war-in 9977819
trigger OldDot sign in as soon as possible
war-in 7e6fcf2
fix public room flow
war-in 3ac1368
fix `Sign out` button flashes
war-in 5f5e645
Merge branch 'war-in/simplify-close-react-native-app-method' into mig…
war-in 72b8eb6
Merge branch 'main' into migrate-hybrid-app-to-new-dot-sign-in-page
mateuuszzzzz cd51f3d
Enable partner name migration to prevent sign-out (#242)
mateuuszzzzz a23c18e
Merge branch 'main' into migrate-hybrid-app-to-new-dot-sign-in-page
mateuuszzzzz 29d8784
Add canBeMissing
mateuuszzzzz 21af8b5
Fix spellcheck
mateuuszzzzz 12da3a0
Merge branch 'main' into migrate-hybrid-app-to-new-dot-sign-in-page
mateuuszzzzz 5222266
Apply prettier
mateuuszzzzz 5de36cf
Fix issue with insets
mateuuszzzzz c0cf815
Fix infinite sign-out
mateuuszzzzz 5cdfe9a
Remove debug methods
mateuuszzzzz 7007f68
Address review comments
mateuuszzzzz 0d07a54
Format code
mateuuszzzzz 49be00c
Handle migration scenario
mateuuszzzzz c307958
Fix BootSplash flicker on sign-out
mateuuszzzzz 95070e8
Merge branch 'main' into migrate-hybrid-app-to-new-dot-sign-in-page
mateuuszzzzz 9fdda10
Merge branch 'main' into migrate-hybrid-app-to-new-dot-sign-in-page
war-in 6643843
clean outdated comments & rename some functions
war-in 028ace1
rename & describe `signInToOldDotAndChooseExperience`
war-in df29f9b
Merge branch 'main' into migrate-hybrid-app-to-new-dot-sign-in-page
war-in 1bf2548
post-merge fixes
war-in 9fb76b0
remove persisted ACCOUNT on sign-out
war-in 54d9c96
Revert "remove persisted ACCOUNT on sign-out"
war-in fbee71b
add logs for better hybridApp sign-in debugability
war-in 0166738
Merge branch 'main' into migrate-hybrid-app-to-new-dot-sign-in-page
war-in File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,16 @@ | ||
| type HybridAppModuleType = { | ||
| isHybridApp: () => boolean; | ||
| shouldUseStaging: (isStaging: boolean) => void; | ||
| closeReactNativeApp: (args: {shouldSignOut: boolean; shouldSetNVP: boolean}) => void; | ||
| closeReactNativeApp: (args: {shouldSetNVP: boolean}) => void; | ||
| completeOnboarding: (args: {status: boolean}) => void; | ||
| switchAccount: (args: {newDotCurrentAccountEmail: string; authToken: string; policyID: string; accountID: string}) => void; | ||
| sendAuthToken: (args: {authToken: string}) => void; | ||
| getHybridAppSettings: () => Promise<string | null>; | ||
| getInitialURL(): Promise<string | null>; | ||
| onURLListenerAdded: () => void; | ||
| signInToOldDot: (args: {autoGeneratedLogin: string; autoGeneratedPassword: string; authToken: string; email: string; policyID: string}) => void; | ||
| signOutFromOldDot: () => void; | ||
| clearOldDotAfterSignOut: () => void; | ||
| }; | ||
|
|
||
| export default HybridAppModuleType; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.