Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"test:debug": "TZ=utc NODE_OPTIONS='--inspect-brk --experimental-vm-modules' jest --runInBand",
"perf-test": "NODE_OPTIONS=--experimental-vm-modules npx reassure",
"typecheck": "NODE_OPTIONS=--max_old_space_size=8192 tsc",
"lint": "NODE_OPTIONS=--max_old_space_size=8192 eslint . --max-warnings=212 --cache --cache-location=node_modules/.cache/eslint",
"lint": "NODE_OPTIONS=--max_old_space_size=8192 eslint . --max-warnings=198 --cache --cache-location=node_modules/.cache/eslint",
"lint-changed": "NODE_OPTIONS=--max_old_space_size=8192 ./scripts/lintChanged.sh",
"lint-watch": "npx eslint-watch --watch --changed",
"shellcheck": "./scripts/shellCheck.sh",
Expand Down
2 changes: 0 additions & 2 deletions src/components/Search/SearchAutocompleteList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,6 @@ function SearchAutocompleteList(
const expenseTypes = Object.values(CONST.SEARCH.TRANSACTION_TYPE).map((value) => getUserFriendlyValue(value));
const withdrawalTypes = Object.values(CONST.SEARCH.WITHDRAWAL_TYPE);
const booleanTypes = Object.values(CONST.SEARCH.BOOLEAN);
const actionTypes = Object.values(CONST.SEARCH.ACTION_FILTERS);

const cardAutocompleteList = useMemo(() => Object.values(allCards), [allCards]);
const feedAutoCompleteList = useMemo(() => {
Expand Down Expand Up @@ -533,7 +532,6 @@ function SearchAutocompleteList(
cardAutocompleteList,
booleanTypes,
workspaceList,
actionTypes,
]);

const sortedRecentSearches = useMemo(() => {
Expand Down
29 changes: 16 additions & 13 deletions src/pages/Share/ShareRootPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -42,19 +42,22 @@ function ShareRootPage() {
const {validateFiles} = useFilesValidation(addValidatedShareFile);
const isTextShared = currentAttachment?.mimeType === 'txt';

const validateFileIfNecessary = (file: ShareTempFile) => {
if (!file || isTextShared || !shouldValidateFile(file)) {
return;
}
const validateFileIfNecessary = useCallback(
(file: ShareTempFile) => {
if (!file || isTextShared || !shouldValidateFile(file)) {
return;
}

validateFiles([
{
name: file.id,
uri: file.content,
type: file.mimeType,
},
]);
};
validateFiles([
{
name: file.id,
uri: file.content,
type: file.mimeType,
},
]);
},
[isTextShared, validateFiles],
);

const appState = useRef(AppState.currentState);
const [isFileReady, setIsFileReady] = useState(false);
Expand Down Expand Up @@ -125,7 +128,7 @@ function ShareRootPage() {
addTempShareFile(tempFile);
}
});
}, [receiptFileFormats, shareFileMimeTypes, translate, errorTitle]);
}, [errorTitle, shareFileMimeTypes, translate, receiptFileFormats, validateFileIfNecessary]);

useEffect(() => {
const subscription = AppState.addEventListener('change', (nextAppState) => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -922,6 +922,7 @@ function IOURequestStepConfirmation({
[
iouType,
transaction,
transactions,
isDistanceRequest,
isMovingTransactionFromTrackExpense,
receiptFiles,
Expand Down
1 change: 0 additions & 1 deletion src/pages/workspace/WorkspacesListPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,6 @@ function WorkspacesListPage() {
translate,
policies,
fundList,
styles.ph5,
styles.mb2,
styles.mh5,
styles.ph5,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ function InviteReceiptPartnerPolicyPage({route}: InviteReceiptPartnerPolicyPageP
shouldShow: true,
},
];
}, [workspaceMembers, debouncedSearchTerm, selectedOptions]);
}, [workspaceMembers, countryCode, debouncedSearchTerm, selectedOptions]);

// Pre-select all members only once on first load.
useEffect(() => {
Expand Down