Skip to content

workspace focus fix - #7040

Merged
Beamanator merged 2 commits into
Expensify:mainfrom
thesahindia:thesahindia/ui-ux/workspace-focus-fix
Jan 7, 2022
Merged

Beamanator merged 2 commits into
Expensify:mainfrom
thesahindia:thesahindia/ui-ux/workspace-focus-fix

Conversation

@thesahindia

Copy link
Copy Markdown
Member

Details

Fixed highlighting issue in workspace

Fixed Issues

$ #7036

Tests

QA Steps

  1. Open app
  2. Navigate to workspace
  3. Click any page and navigate back out

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen.Recording.2022-01-05.at.11.56.05.PM.mov

Mobile Web

Desktop

iOS

Android

@thesahindia
thesahindia requested a review from a team as a code owner January 5, 2022 18:54
@MelvinBot
MelvinBot requested review from Beamanator and rushatgabhane and removed request for a team January 5, 2022 18:54
rushatgabhane
rushatgabhane previously approved these changes Jan 5, 2022

@rushatgabhane rushatgabhane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well on mobile and web. LGTM!

@Beamanator all yours!

@rushatgabhane

Copy link
Copy Markdown
Member

@Beamanator good for review.

@Beamanator
Beamanator self-requested a review January 7, 2022 05:08

@Beamanator Beamanator left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 💪

@Beamanator
Beamanator merged commit 7af06bc into Expensify:main Jan 7, 2022
@OSBotify

OSBotify commented Jan 7, 2022

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Jan 10, 2022
24 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @Beamanator in version: 1.1.26-2 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @Beamanator in version: 1.1.27-0 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.27-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants