Repository navigation
fix: delete expense in offline remove them immediately - #71154
Conversation
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-09-28.at.14.32.32.movAndroid: mWeb ChromeScreen.Recording.2025-09-28.at.14.21.40.moviOS: HybridAppScreen.Recording.2025-09-28.at.14.34.34.moviOS: mWeb SafariScreen.Recording.2025-09-28.at.14.20.41.movMacOS: Chrome / SafariScreen.Recording.2025-09-28.at.14.16.21.movMacOS: DesktopScreen.Recording.2025-09-28.at.14.18.50.mov |
|
@nkdengineer Could you please try merging with the latest main to resolve the pipeline failure caused by PR reviews with Claude Code? |
neil-marcellini
left a comment
There was a problem hiding this comment.
it looks great, but please add a unit test as you said you would in your proposal.
|
@neil-marcellini @suneox i updated |
neil-marcellini
left a comment
There was a problem hiding this comment.
Thanks, good to go now
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.2.21-0 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.2.21-4 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.2.21-4 🚀
|
Explanation of Change
Fixed Issues
$ #70185
PROPOSAL: #70185 (comment)
Tests
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
android.mov
iOS: Native
ios.mov
iOS: mWeb Safari
ios-mweb.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
de.mov