Repository navigation
Report - White screen displayed briefly when trying to add a receipt to an expense - #71754
Conversation
Codecov Report❌ Patch coverage is
... and 9 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Sorry @ikevin127, please ignore this assignment. It was my bad when I attach the wrong issue in PR desc |
|
@jjcoffee Ping here for review since there is no assignment for you on this PR due to the issue above ^ |
|
@lorretheboy Can you add screenshots for all platforms? |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid-app-2025-10-17_11.46.46.mp4Android: mWeb Chromeandroid-chrome-2025-10-17_11.50.50.mp4iOS: HybridAppios-app-2025-10-17_12.19.22.mp4iOS: mWeb Safariios-safari-2025-10-17_12.22.17.mp4MacOS: Chrome / Safaridesktop-chrome-2025-10-06_17.02.26.mp4MacOS: Desktopdesktop-app-2025-10-06_17.05.33.mp4 |
Sure, lemme add them. The reason I left them empty is because we only have changes in native file |
|
@Expensify/design Just wanted to get a quick gut check on the change we're making here. We've added a loader instead of the blank screen that was showing previously (there's an alternative option here). android-app-2025-10-06_17.28.20.mp4 |
|
Can we see the video in dark mode too? Just to make sure we're fixing the bug that was reported, this video basically: CleanShot.2025-10-06.at.17.40.03.mp4Do we even need the page with a spinner, or is there just a way to get rid of that interim blip altogether? No strong feelings as I think the loader is fine, but just curious if we can completely eliminate that white screen? |
|
@jjcoffee There is a way to remove the empty screen It was caused in the IOURequestStepScan component: The camera permission check was wrapped in InteractionManager.runAfterInteractions(), which introduced a delay. We can just remove that App/src/pages/iou/request/step/IOURequestStepScan/index.native.tsx Lines 234 to 237 in 875d4b7 |
|
@lorretheboy Looks like that was added in #38270. Somehow seems unlikely that this has been an issue for over a year without anyone noticing, but if you're able to remove it without any regressions I'm all for it. Can you test against the test steps in #38270? |
|
@jjcoffee I think we are safe to remove the ios.movandroid.mov |
|
@lorretheboy Nice! Could you push that change then, and I'll retest. |
|
@jjcoffee Please help check again. I have updated the PR |
|
@lorretheboy Thanks! Reviewing today. Can you resolve conflicts in the meantime? |
jjcoffee
left a comment
There was a problem hiding this comment.
LGTM! Just needs conflicts resolving.
|
@jjcoffee I have resolved the conflicts |
|
All yours @JS00001! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.2.34-0 🚀
|
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.34-2 🚀
|
Explanation of Change
Fixed Issues
$ #70928
PROPOSAL: #70928 (comment)
Tests
Prerequisite: Account has at least one workspace available.
Offline tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
website.android.mov
iOS: Native
ios.mov
iOS: mWeb Safari
website.ios.mov
MacOS: Chrome / Safari
website.mov
MacOS: Desktop
desktop.mov