Repository navigation
fix:70170: delay navigation to memberDetails page from members page - #71756
Conversation
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report❌ Patch coverage is
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
@Eskalifer1 |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2025-10-17.09.41.26.movAndroid: mWeb Chrome2025-10-17.09.42.53.moviOS: HybridApp2025-10-17.09.23.38.moviOS: mWeb Safari2025-10-17.09.21.57.movMacOS: Chrome / Safari2025-10-17.09.15.31.movMacOS: Desktop2025-10-17.09.15.31.mov |
|
Hi @ZhenjaHorbach, Yes, I saw this news, but I'm not sure yet that we can use this approach, because I don't see any use for this feature in the project, and InteractionManager has not yet been added to the eslint rules. Besides, are we sure we want to use this approach, since this feature has not yet been added to BaseLine (Limited availability) on mdn: Perhaps we need to agree on what approach to use in the project now, since this feature is used in many places. |
We're already working on it |
|
PR updated! |
|
Hi @ZhenjaHorbach, what do you think about using What do you think? Let me know if I need to update the PR. Thank you! |
Actually yes |
|
Updated PR! |
|
LGTM! |
|
@Eskalifer1, can you merge main? We have a stuck check and that should fix it. |
|
Merged main! cc: @Gonals |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/Gonals in version: 9.2.34-0 🚀
|
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.34-2 🚀
|
Explanation of Change
Fixed Issues
$#70170
PROPOSAL:#70170 (comment)
Tests
Offline tests
Precondition: have created workspace
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
70170.-.android-native.mov
Android: mWeb Chrome
70170.-.android-web.mov
iOS: Native
70170.-.ios-native.mov
iOS: mWeb Safari
70170.-.ios-web.mov
MacOS: Chrome / Safari
70170.-.web.mov
MacOS: Desktop
70170.-.desktop.mov