Repository navigation
[Part 1]: Using buildNextStepNew function in IOU.ts - #72104
Conversation
rojiphil
left a comment
There was a problem hiding this comment.
@DylanDylann Overall code LGTM but I have also left few comments. Also, looks like reimbursableSpend got missed in buildNextStepNew.
Please have a look. Thanks
|
Hey @rojiphil This PR is part of the Onyx.connect deprecate project, Do you mind if i take over the review ? saying since we distributed the work in parts and this is 3rd part PR in the process, we already merged 2 PR's for this issue |
@allgandalf Sure... That's fine. It is all yours. |
|
Thanks :) |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2025-10-14.at.2.30.14.PM.mov |
|
Completing the checklist now |
|
@DylanDylann conflicts |
23ef75e to
edad943
Compare
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
| const [introSelected] = useOnyx(ONYXKEYS.NVP_INTRO_SELECTED, {canBeMissing: true}); | ||
| const [allBetas] = useOnyx(ONYXKEYS.BETAS, {canBeMissing: true}); | ||
| const [allTransactionViolations] = useOnyx(ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS, {canBeMissing: true}); | ||
| const isASAPSubmitBetaEnabled = Permissions.isBetaEnabled(CONST.BETAS.ASAP_SUBMIT, allBetas); |
There was a problem hiding this comment.
@DylanDylann @allgandalf @danieldoglas Please fix these usages. You need to use isBetaEnabled from usePermissions hook here.
There was a problem hiding this comment.
will fix here: https://github.com/Expensify/App/pull/72913/files
|
🚀 Deployed to staging by https://github.com/danieldoglas in version: 9.2.34-0 🚀
|
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.34-2 🚀
|
Explanation of Change
Fixed Issues
$ #66365
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Screen.Recording.2025-10-09.at.09.54.28.mov
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop