Repository navigation
Implement confirmation modal when user tries to create multiple empty reports - #72884
Conversation
|
@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Will test for the staging issues soon. |
|
Will review today |
|
@ShridharGoel Can you merge main please? |
|
I can verify that all these linked blockers were fixed. Please update the QA steps to include them as well. Thanks |
|
@hungvu193 Updated |
|
Cool. LGTM. I'll complete the checklist in the morning. |
|
Status: Oops I think I still can reproduce this one (#72824). Can you double check? Steps to reproduce:
|
|
@hungvu193 Thanks for finding this. #72824 actually talks about a different button. I believe the "Create report" we see with "No expenses to submit" kind of modals has a different handling as compared to the one we see with "You haven't created any reports yet". But the steps you mentioned are valid, and I feel that's a different bug. It says "You haven't created any reports yet" even though the user already has empty reports (same happens on staging). So, I think we shouldn't be showing that dialog at all? And instead show another one without a create report button. What do you think? |
Agree. @puneetlath Curious your thoughts on this one. |
|
@puneetlath Gentle bump on the above question. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid.movAndroid: mWeb ChromeScreen.Recording.2025-10-07.at.16.39.51.moviOS: HybridAppios.moviOS: mWeb SafarimSafari.movMacOS: Chrome / SafariChrome1.movChrome.movMacOS: DesktopDesktop.mov |
|
@ShridharGoel We still have linting 🥲 |
|
That actually seemed unrelated when I last checked, any idea why it's showing up even after merging main? |
|
It looks like we deprecated |
|
@puneetlath Can you have a look now? |
|
Approved. Looks like eslint is failing though. |
|
That is an unrelated failure
|
|
Is it happening on main too? |
|
No, but this is the reason:
#72884 (comment)
|
|
Ok got it. I think the idea there is that when you update a file, you also address any lint issues in that file. Are there a lot of changes needed to fix that error? |
|
@puneetlath Looks like other places in the project have just disabled the deprecation warning for now, so now did the same here. Lint should pass now. It is being tracked here. |
|
@puneetlath Gentle bump on this. |
|
Thanks for addressing! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.2.42-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.42-11 🚀
|
Explanation of Change
Implement confirmation modal when user tries to create multiple empty reports.
Fixed Issues
$ #70999
PROPOSAL: #70999 (comment)
Tests
Precondition: Have no default workspace and two non-default workspaces.
Precondition: Have no default workspace and two non-default workspaces.
Precondition: Device is Android 16. Device font size should be the first three smallest size.
Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-10-02.at.5.30.00.PM.mp4
Android: mWeb Chrome
Screen.Recording.2025-10-02.at.4.42.31.PM.mp4
iOS: Native
Simulator.Screen.Recording.-.iPhone.16.Plus.-.2025-10-02.at.22.49.25.-.FPS.-.Videobolt.net.mp4
iOS: mWeb Safari
Simulator.Screen.Recording.-.iPhone.16.Plus.-.2025-10-02.at.21.56.56.-.COMPRESS.mp4
MacOS: Chrome / Safari
Screen.Recording.2025-10-02.at.3.34.29.PM.1.online-video-cutter.com.1.mp4
MacOS: Desktop
Screen.Recording.2025-10-02.at.11.07.13.PM.mp4