Repository navigation
[No QA] Clarify setup instructions for QuickBooks Online to add vendors - #72995
Conversation
Updated the instructions to clarify that both employees and vendors need to be set up in QuickBooks Online.
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@twisterdotcom Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
HelpDot Documentation ReviewOverall AssessmentThis PR makes a focused improvement to QuickBooks Online connection instructions by clarifying that both employees and vendors need to be set up in QuickBooks Online. The change is minimal but addresses an important gap in the original documentation. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This is a straightforward documentation improvement that addresses a real user need by clarifying setup requirements for both employee and vendor scenarios. |
|
A preview of your ExpensifyHelp changes have been deployed to https://8316d127.helpdot.pages.dev ⚡️ Updated articles: |
|
@muttmuure a couple of requests from the AI reviewer, then LMK and I'll review it. |
|
Fixing this today |
|
Updated the bits it wanted changes to |
|
🚀 Deployed to staging by https://github.com/twisterdotcom in version: 9.2.42-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.42-11 🚀
|
Updated the instructions to clarify that both employees and vendors need to be set up in QuickBooks Online.
Explanation of Change
Fixed Issues
$https://expensify.slack.com/archives/C02QSAC6BJ8/p1760955297607279
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop