Skip to content

[CP Staging] Revert "feat: allow adding receipt on manual distance request" - #73028

Merged
blimpich merged 1 commit into
mainfrom
revert-70975-fix/68874
Oct 20, 2025
Merged

blimpich merged 1 commit into
mainfrom
revert-70975-fix/68874

Conversation

@blimpich

Copy link
Copy Markdown
Contributor

Reverts #70975

@blimpich blimpich self-assigned this Oct 20, 2025
@blimpich
blimpich requested a review from a team as a code owner October 20, 2025 18:05
@melvin-bot
melvin-bot Bot requested review from marcaaron and removed request for a team October 20, 2025 18:05
@melvin-bot

melvin-bot Bot commented Oct 20, 2025

Copy link
Copy Markdown

@marcaaron Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions

Copy link
Copy Markdown
Contributor

LGTM :feelsgood:. Thank you for your hard work!

@codecov

codecov Bot commented Oct 20, 2025 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/libs/IOUUtils.ts 33.33% 2 Missing ⚠️
Files with missing lines Coverage Δ
.../components/MoneyRequestConfirmationListFooter.tsx 56.41% <100.00%> (ø)
src/libs/actions/IOU.ts 63.16% <100.00%> (ø)
...es/iou/request/step/IOURequestStepConfirmation.tsx 48.27% <100.00%> (+0.11%) ⬆️
src/libs/IOUUtils.ts 61.76% <33.33%> (-0.62%) ⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blimpich
blimpich merged commit 717cd97 into main Oct 20, 2025
2 checks passed
@blimpich
blimpich deleted the revert-70975-fix/68874 branch October 20, 2025 18:20
@melvin-bot melvin-bot Bot added the Emergency label Oct 20, 2025
@melvin-bot

melvin-bot Bot commented Oct 20, 2025

Copy link
Copy Markdown

@blimpich looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify pushed a commit that referenced this pull request Oct 20, 2025
(cherry picked from commit 717cd97)

(cherry-picked to staging by blimpich)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Oct 20, 2025
@OSBotify OSBotify mentioned this pull request Oct 20, 2025
44 tasks done
@blimpich

Copy link
Copy Markdown
Contributor Author

Not emergency, straight revert

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/blimpich in version: 9.2.34-1 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@blimpich blimpich changed the title Revert "feat: allow adding receipt on manual distance request" [CP Staging] Revert "feat: allow adding receipt on manual distance request" Oct 20, 2025
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.34-2 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/blimpich in version: 9.2.35-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@marcaaron
marcaaron removed their request for review October 21, 2025 21:21
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/blimpich in version: 9.2.35-4 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants