Repository navigation
Remove brackets and hyphen from phone number input #7328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
thesahindia
wants to merge
15
commits into
Expensify:main
from
thesahindia:thesahindia/ux-ui/phone-text-input
Closed
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
c06487d
use PhoneTextInput
thesahindia 6c60ccc
merge main
thesahindia 4e7105b
add validation for phone number
thesahindia 3793152
cleanup
thesahindia 52ea585
make suggested changes
thesahindia 360a487
Merge branch 'main' of github.com:thesahindia/App into thesahindia/ux…
thesahindia c11fd4c
make suggested changes
thesahindia ffe9768
minor changes
thesahindia 200cf22
minor change
thesahindia aeb428b
small change
thesahindia 5b30c93
merge main
thesahindia 5e54b73
use PhoneTextInput
thesahindia 28a4f8f
update error message and placeholder
thesahindia 2eab7c4
resolve conflicts
thesahindia 0aa92fc
change error message
thesahindia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| import React from 'react'; | ||
|
thesahindia marked this conversation as resolved.
Resolved
|
||
| import * as baseTextInputPropTypes from '../TextInput/baseTextInputPropTypes'; | ||
| import TextInput from '../TextInput'; | ||
| import * as LoginUtils from '../../libs/LoginUtils'; | ||
|
|
||
| class PhoneTextInput extends React.Component { | ||
| constructor(props) { | ||
| super(props); | ||
|
|
||
| this.state = { | ||
| value: props.value || props.defaultValue || '', | ||
| }; | ||
| this.setValue = this.setValue.bind(this); | ||
| } | ||
|
|
||
| setValue(value) { | ||
| this.setState({value}); | ||
| this.props.onChangeText(LoginUtils.getPhoneNumberWithoutSpecialChars(value)); | ||
| } | ||
|
|
||
| render() { | ||
| return ( | ||
| <TextInput | ||
| ref={this.props.forwardedRef} | ||
| // eslint-disable-next-line react/jsx-props-no-spreading | ||
| {...this.props} | ||
| value={this.state.value} | ||
| onChangeText={this.setValue} | ||
| /> | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| PhoneTextInput.propTypes = baseTextInputPropTypes.propTypes; | ||
| PhoneTextInput.defaultProps = baseTextInputPropTypes.defaultProps; | ||
|
|
||
| export default React.forwardRef((props, ref) => ( | ||
| /* eslint-disable-next-line react/jsx-props-no-spreading */ | ||
| <PhoneTextInput {...props} forwardedRef={ref} /> | ||
| )); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.