Repository navigation
Fix map preview resizing issue after edit causing partial area rendering - #74023
Conversation
|
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
LGTM 👍 Thank you for your hard work! |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
Videos look good to me 👍 Assuming it still works if you completely change the route as well not just flip the start/stop? |
|
@nabi-ebrahimi What was the cause of the regression and why are we making the new change of |
|
@abdulrahuman5196 thanks for the review Cause of regression: |
I need to validate on this. Will check and update here |
|
checking now |
|
@nabi-ebrahimi Questions on the analysis. The actual change we are making is adding flex to make sure the map preview grows, which we have made.
But I have trouble understanding why we need to disable aspect ratio in full screen modals? Specifically related to the regression we saw here #73602, it happened on chat page itself which is not modal/fullscreen. How is this fixing that regression?
Also In the last PR which caused regression we only added flex - https://github.com/Expensify/App/pull/73298/files. If the above is true and flex is ignored it should have ignored our change and shouldn't have cause regression. Can you provide more information on these and the cause of the regression and how is this fixing that regression as well as the original intented fix? |
@abdulrahuman5196 You’re right. After investigating further, I found that the issue only occurs in the |
|
@nabi-ebrahimi could you kindly provide RCA on how this change will fix the original issue without causing the past regression. I am having trouble understanding the part. |
|
@abdulrahuman5196 The original issue was that the App/src/components/ReceiptImage/index.tsx Lines 228 to 235 in cad3533 This does not introduce the previous regression, as the new changes do not impact the App/src/components/ImageWithSizeCalculation.tsx Lines 77 to 85 in cad3533 |
|
@abdulrahuman5196 Thanks for the review! Please let me know if you need any more details to understand the changes. |
|
@abdulrahuman5196, friendly bump — please take a look at my new comments when you get a chance. Thanks! |
|
@nabi-ebrahimi At this point I am not sure if we are at the right fix, since we have been changing the code drastically for each question. For each change we have to re-test and re-add the screen recordings. Since we have new changes could you re-test this #72191 as well as this #73602 usecase and update the PR Author checklist? I can check on this then. |
|
@abdulrahuman5196 Thanks for checking. I’ve re-tested both issues on all six platforms. How would you like me to update the PR author checklist? |
|
@nabi-ebrahimi Yes. PR author checklist are expected to updated with new changes and the screen recordings as well |
|
@abdulrahuman5196 Thanks for the feedback. I’ve updated the PR author checklist—please take a look when you get a chance. |
| lastUpdateWidthTimestampRef.current = e.timeStamp; | ||
| }} | ||
| source={typeof source === 'string' ? {uri: source} : source} | ||
| style={[style ?? [styles.w100, styles.h100], styles.overflowHidden]} |
There was a problem hiding this comment.
why are we removing a style being passed, ? Some component could be passing this as a param for custom style? @nabi-ebrahimi Have we checked this usages?
There was a problem hiding this comment.
And Receipt image is not just being used in a single place of RHP
There was a problem hiding this comment.
@abdulrahuman5196, if you check carefully, this style was being ignored in the child component. It wasn’t applied at all, so I removed it.
{...rest}
style={[styles.w100, styles.h100]}And i checked no parent component have passed the style prop to Receipt image component for cases we return ImageWithLoading.
So my changes are safe.
Screen.Recording.2025-12-08.at.11.23.13.PM.mov@nabi-ebrahimi I am seeing issue where the map image is not showing in the messages. could you kindly check on this? |
|
@abdulrahuman5196, when you have a moment, could you re-test this or provide the specific steps you followed to reproduce the problem? I wasn’t able to see the issue on my end. Thank you! Screen.Recording.1404-09-19.at.7.26.12.PM.mp4 |
|
Not any specific tests, just the normal flow. Let me try again. |
|
@abdulrahuman5196, Quick bump. thanks |
|
@abdulrahuman5196, please take another look when you get a chance. thanks |
|
Hi, Checking again today. |
|
@abdulrahuman5196, Quick bump, thanks |
|
checking now |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-12-23.at.5.10.15.PM.movAndroid: mWeb ChromeScreen.Recording.2025-12-23.at.5.13.38.PM.moviOS: HybridAppScreen.Recording.2025-12-23.at.4.31.44.PM.moviOS: mWeb SafariScreen.Recording.2025-12-23.at.4.34.12.PM.movMacOS: Chrome / SafariScreen.Recording.2025-12-23.at.4.29.46.PM.mov |
abdulrahuman5196
left a comment
There was a problem hiding this comment.
Changes looks good and works well. Reviewers checklist is also complete.
All yours. @inimaga
🎀 👀 🎀
C+ Reviewed
inimaga
left a comment
There was a problem hiding this comment.
Looks good. Thanks both. 🚀
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/inimaga in version: 9.2.87-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.2.87-7 🚀
|
Explanation of Change
Fixed Issues
$ #72191
PROPOSAL: #72191 comment
Tests
→ The distance receipt preview fills the area completely while the map is updating.
Offline tests
Same as Tests
QA Steps
Same as Tests
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.1404-09-08.at.1.46.43.PM.mov
Android: mWeb Chrome
Screen.Recording.1404-09-08.at.1.49.34.PM.mov
iOS: Native
ios-native.mp4
iOS: mWeb Safari
Screen.Recording.1404-09-08.at.1.54.09.PM.mp4
MacOS: Chrome / Safari
Screen.Recording.1404-09-08.at.1.42.45.PM.mp4