Repository navigation
Fix distance rate upgrade flow by passing the proper parameter - #74511
Merged
Merged
Conversation
melvin-bot
Bot
requested review from
heyjennahay and
jjcoffee
and removed request for
a team
November 6, 2025 20:49
blimpich
approved these changes
Nov 6, 2025
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
Contributor
Author
|
@heyjennahay in case you're wondering, I decided to go ahead without your product approval because this was a simple bug fix with no UX changes. |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
48 tasks done
Contributor
|
🚀 Deployed to staging by https://github.com/blimpich in version: 9.2.47-0 🚀
|
5 of 8 tasks
6 of 8 tasks
Contributor
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.47-1 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
In the linked issue a bug was reported with the distance rate upgrade flow because it was not properly setting the receiver of the expense as the workspace admin on the newly created workspace. The problem was that the param
areDistanceRatesEnabledwas not passed to the API, and it requires that to be true in order to do anything with the memberData. Now we're passing this parameter. I added a unit test to assert this.Fixed Issues
$ #73483
PROPOSAL: N/A
Tests
2025-11-06_15-43-47.mp4
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
See the test above on Chrome. Changes are simple and platform independent.
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop