Repository navigation
Fix: changed the expense message appears when splitting expense and then reverting the split
#74660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8f39150
Fix: 'Changed the amount' message appears when splitting expense and …
nyomanjyotisa 5a78a1b
ESLint fix
nyomanjyotisa a6136c0
Fix: 'Changed the amount' message appears when splitting expense and …
nyomanjyotisa 2ad7ca3
Merge branch 'main' into issue-74265
nyomanjyotisa 73b42b2
Fix: Remove transactionID from transactionChanges in reverse split op…
nyomanjyotisa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry but I don't get why we delete
transactionChanges.transactionIDin this case, can you explain?Also that was not the solution proposed in the proposal in the issue, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue solved in this PR is different from the original GH issue. It seems like the original GH issue is the expected behavior based on this comment. In this PR, we address case 2 from that comment to prevent showing any system message when user perform a reverse split and set the remaining expense back to its original amount
And then, we delete
transactionChanges.transactionIDwhen we reverse a split because thetransactionIDis different in this case. This causes thetransactionIDto remain intransactionChanges, and we get the "changed the expense" system message even when the user makes no change at all. I explained the detailed RCA and solution here