Repository navigation
[No QA] Add support for waitingToExport report next step - #75759
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@dangrous, we don't need an optimistic next step for the "Waiting to Export" next step, right? Since it only occurs when the client is online. |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
What comes right before that next step? I think we would need it to be optimistic if, say, the admin approved the report while offline? Or maybe I'm misunderstanding the flow. There are so many different states! If we don't need optimistic than this is good to go once we confirm the spanish |
I think the next step before this next step can be:
But, I think, based on this issue, we only want to display this next step when the report export action failed, right?
App/src/libs/ReportPrimaryActionUtils.ts Lines 186 to 230 in 2b911a4 App/src/libs/ReportSecondaryActionUtils.ts Lines 315 to 356 in 2b911a4
Lines 11992 to 12009 in 2b911a4 Lines 11954 to 11991 in 2b911a4
App/src/libs/actions/Report.ts Lines 4651 to 4688 in 2b911a4 This function adds the optimistic
Lines 761 to 1127 in 2b911a4 I don't think we can predict export failure. The client only receives failure data from the server while online. Export is a server-side process, and nothing in the client can reliably infer that the export will fail, and the failure signal only arrives after the server attempts the export. Please let me know if this makes sense! |
|
Oh yep yep, my mistake! Yes we would never have an optimistic failure, so we should be good |
|
@s77rt are you able to complete the PR checklist here? |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/dangrous in version: 9.2.65-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.65-6 🚀
|
Explanation of Change
This next step was added in these PRs: https://github.com/Expensify/Web-Expensify/pull/49036 and https://github.com/Expensify/Auth/pull/17702
This PR adds support for it in the new report next step format in NewDot.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/528713
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop