Repository navigation
Revert "Android - Reports -Empty space created at the end of filters row when clearing "From" filter" - #76224
Conversation
…row when clearing "From" filter"
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@marcaaron looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
Not emergency straight revert |
…space-issue Revert "Android - Reports -Empty space created at the end of filters row when clearing "From" filter" (cherry picked from commit 50bfa83) (cherry-picked to staging by marcaaron)
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 9.2.65-4 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.65-6 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 9.2.66-0 🚀
|
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.2.66-3 🚀
|
Explanation of Change
Reverts #74920
Fixed Issues
$ #76197
Tests
Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari