Repository navigation
Fix : Reports - Expense that doesn´t fit a search, is displayed on results when added offline - #76447
Merged
Merged
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
melvin-bot
Bot
requested review from
trjExpensify
and removed request for
a team
December 2, 2025 19:49
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-12-03.at.7.24.28.PM.movAndroid: mWeb ChromeScreen.Recording.2025-12-03.at.7.25.39.PM.moviOS: HybridAppScreen.Recording.2025-12-03.at.7.20.48.PM.moviOS: mWeb SafariScreen.Recording.2025-12-03.at.7.23.34.PM.movMacOS: Chrome / SafariScreen.Recording.2025-12-03.at.7.22.38.PM.mov |
eh2077
approved these changes
Dec 3, 2025
eh2077
left a comment
Contributor
There was a problem hiding this comment.
looks good, thank you for adding unit tests!
Contributor
|
@M00rish I'm not sure why code coverage report says #76447 (comment) this patch coverage is 0%. It seems unit test added isn't counted. Can you look into it a bit? |
JS00001
approved these changes
Dec 3, 2025
carlosmiceli
approved these changes
Dec 3, 2025
60 tasks done
Contributor
|
🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.2.72-0 🚀
|
3 of 8 tasks
Contributor
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.2.72-2 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #75137
PROPOSAL: comment
Tests
Prerequisite: Account has at least two workspaces.
Prerequisite 2: One workspace has expenses created in it.
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen_Recording_20251202_172133_New.Expensify.mp4
Android: mWeb Chrome
AndroidWeb.webm
iOS: Native
IOS.webm
iOS: mWeb Safari
IOSWeb.webm
MacOS: Chrome / Safari
web.webm